[Home]

Summary:ASTERISK-03119: [patch] AGIs continue even if a file was not found.
Reporter:Clod Patry (junky)Labels:
Date Opened:2004-12-31 14:58:25.000-0600Date Closed:2008-01-15 15:19:36.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_agi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) continue_agi.txt
Description:When you try to STREAM FILE foobar, and that file "foobar" isn't found. The AGI stops when trying to stream it.
That patch allows the AGI to continue, even if "foobar" isn't found.

I've took off the "ast_log(LOG_WARNING, "Unable to open %s\n", argv[2]);", cause ast_openstream_full already gives a WARNING and there's no need to have 2 warnings for 1 file not-found

****** ADDITIONAL INFORMATION ******

Here's my part of AGI:
print "STREAM FILE vm-intro2 \"\"\n";
my $result = <STDIN>;
print "SAY DIGITS 123 \"\"\n";
my $result = <STDIN>;

Without the patch:
Dec 31 15:40:09 WARNING[19813]: file.c:482 ast_openstream_full: File vm-intro2 does not exist in any format
Dec 31 15:40:09 WARNING[19813]: res_agi.c:436 handle_streamfile: Unable to open vm-intro2
 == Spawn extension (test_sip, 3203, 1) exited non-zero on 'SIP/101-6940'

Remark there's no say digits 123 in this case.


With the patch:
Dec 31 15:37:43 WARNING[17938]: file.c:482 ast_openstream_full: File vm-intro2 does not exist in any format
   -- Playing 'digits/1' (language 'en')
   -- Playing 'digits/2' (language 'en')
   -- Playing 'digits/3' (language 'en')
   -- AGI Script nofile.agi completed, returning 0

remark the say digits 123 occurs sucessfully.

Disclaimer on file
Comments:By: Mark Spencer (markster) 2004-12-31 16:58:21.000-0600

Fixed in CVS head.  Oops, kinda a big oversight hehe.
By: Russell Bryant (russell) 2005-01-03 12:14:13.000-0600

fixed in 1.0 as well
By: Digium Subversion (svnbot) 2008-01-15 15:19:14.000-0600

Repository: asterisk
Revision: 4623

U   trunk/res/res_agi.c

------------------------------------------------------------------------
r4623 | markster | 2008-01-15 15:19:13 -0600 (Tue, 15 Jan 2008) | 2 lines

Don't die when a file is missing (bug ASTERISK-3119)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4623
By: Digium Subversion (svnbot) 2008-01-15 15:19:36.000-0600

Repository: asterisk
Revision: 4648

U   branches/v1-0/res/res_agi.c

------------------------------------------------------------------------
r4648 | russell | 2008-01-15 15:19:35 -0600 (Tue, 15 Jan 2008) | 2 lines

don't exit AGI when file not found to stream (bug ASTERISK-3119)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4648