Summary:ASTERISK-03113: [patch] Speex configuration broken for ABR.
Reporter:stevekstevek (stevekstevek)Labels:
Date Opened:2004-12-28 12:31:36.000-0600Date Closed:2008-01-15 15:18:54.000-0600
Versions:Frequency of
Environment:Attachments:( 0) speex.patch
Description:The present configuration item for speex is broken for the case of ABR. Presently, if you choose ABR in your config, it just sets VBR mode..

For ABR, you choose a target bitrate, not a quality.  

This patch removes the abr_quality parameter (you get a warning), and changes the abr parameter to choose a target bitrate).  codecs.conf.sample changes included.

"false" is interpreted as zero, so old configs just won't use abr.

Also, "VAD" and "DTX" are implicit when VBR/ABR are used, so it's not helpful to set them.

Setting abr with a bitrate of 8000 sounds pretty good, and uses very little bandwidth.

Comments:By: Brian West (bkw918) 2004-12-29 20:24:55.000-0600

kewl kewl


By: Mark Spencer (markster) 2004-12-29 20:46:08.000-0600

Fixed in CVS, thanks.  Next time mention your disclaimer for your +1!

By: Digium Subversion (svnbot) 2008-01-15 15:18:54.000-0600

Repository: asterisk
Revision: 4601

U   trunk/codecs/codec_speex.c
U   trunk/configs/codecs.conf.sample

r4601 | markster | 2008-01-15 15:18:54 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix Speex config issue (bug ASTERISK-3113)