[Home]

Summary:ASTERISK-03078: [PATCH] add AST_FLAGS_ALL mask and ensure flags are unsigned
Reporter:Kevin P. Fleming (kpfleming)Labels:
Date Opened:2004-12-22 22:58:36.000-0600Date Closed:2008-01-15 15:18:02.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) flags_copy_all_rev1.diff.txt
Description:This patch does two things:

- adds an AST_FLAGS_ALL constant to be used with ast_copy_flags for copying all the flags present

- changes struct ast_flags to use unsigned int for flags, so that bit 31 and 32 can be used properly

If someone wants to document these flag macros, it might be a good idea to recommend always using an unsigned int to store them, to avoid sign-extension issues.

****** ADDITIONAL INFORMATION ******

Disclaimer is on file.
Comments:By: Olle Johansson (oej) 2004-12-23 01:12:58.000-0600

Please add doxygen comments with the information you provided, so that we have documentation!

By: Mark Spencer (markster) 2004-12-23 06:36:43.000-0600

Added to CVS head.  I also included "limits.h" to be on the safe side.

By: Digium Subversion (svnbot) 2008-01-15 15:18:02.000-0600

Repository: asterisk
Revision: 4543

U   trunk/include/asterisk/utils.h

------------------------------------------------------------------------
r4543 | markster | 2008-01-15 15:18:02 -0600 (Tue, 15 Jan 2008) | 2 lines

Add "ast_flags_all" mask (bug ASTERISK-3078)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4543