| Summary: | ASTERISK-03074: [patch] Wrong US tone freqs in chan_vpb.c | ||
| Reporter: | Paul Dugas (pdugas) | Labels: | |
| Date Opened: | 2004-12-22 17:29:19.000-0600 | Date Closed: | 2008-01-15 15:17:57.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) patch-2003122201.gz | |
| Description: | Dialtone sounded wierd using a Voicetronix OpenSwitch6 card and the vpb-2.4.0 driver. Not terribly familiar with the * code but think I've managed to track it down to the definition of Dialtone in chan_vpb.c. The HEAD version has the USA definitions disabled. I enabled them, disabled the AU ones, and got similarly wierd sounding tones. Changed the three tone definitions to match (I think) the [us] section in indications.conf. Sounds right to my untrained ear. Patch attached. ****** ADDITIONAL INFORMATION ****** As an asside, would it be possible to have these VPB_TONE structures populated based on the indications.conf file rather than having the data in multiple places? | ||
| Comments: | By: Mark Spencer (markster) 2004-12-22 20:50:48.000-0600 Merged in CVS, but I left Australia as the default as it was before your patch. Thanks! By: Digium Subversion (svnbot) 2008-01-15 15:17:57.000-0600 Repository: asterisk Revision: 4537 U trunk/channels/chan_vpb.c ------------------------------------------------------------------------ r4537 | markster | 2008-01-15 15:17:57 -0600 (Tue, 15 Jan 2008) | 2 lines Fix US tones (bug ASTERISK-3074) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4537 | ||