[Home]

Summary:ASTERISK-03072: [patch] Use ast_flag macros for app_voicemail && fix a buglet
Reporter:Russell Bryant (russell)Labels:
Date Opened:2004-12-22 16:33:08.000-0600Date Closed:2008-01-15 15:18:11.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) vmflags.diff.txt
Description:This patch uses the flag macros for a lot of options in app_voicemail.

I think I may have stumbled across a little bug along the way.  In populate_defaults, it just sets the attach option to -1 instead of copying it from the global setting like the rest of the options.  See the following snippet:

...
static void populate_defaults(struct ast_vm_user *vmu)
{
       vmu->attach = -1;
       if (reviewvm)
               vmu->review = 1;
...

Also, as far as I can tell, there is no significance to setting it to -1 instead of zero.

****** ADDITIONAL INFORMATION ******

disclaimer is on file
Comments:By: Mark Spencer (markster) 2004-12-22 20:42:13.000-0600

Added to CVS, thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:17:55.000-0600

Repository: asterisk
Revision: 4535

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r4535 | markster | 2008-01-15 15:17:55 -0600 (Tue, 15 Jan 2008) | 2 lines

Use flags for voicemail (bug ASTERISK-3072)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4535
By: Digium Subversion (svnbot) 2008-01-15 15:18:11.000-0600

Repository: asterisk
Revision: 4553

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r4553 | russell | 2008-01-15 15:18:11 -0600 (Tue, 15 Jan 2008) | 2 lines

fix flag error (bug ASTERISK-3072)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4553