[Home]

Summary:ASTERISK-03057: [patch] No Newcallerid manager events on callerid changes in chan_zap.c
Reporter:gonzo gonzo (gonzo)Labels:
Date Opened:2004-12-21 12:48:26.000-0600Date Closed:2008-01-15 15:20:07.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) callerid-cleanup-chan_zap.diff
Description:strdup() was used for setting callerid on channel instead of
ast_set_callerid() routine call - that's why it is impossible to trace Newcallerid event using Manager API for Zap channels. So i've performed some cleanup on chan_zap.c The same tweaks are in chan_sip.c as well, so i think they should be fixed as well. I the patch is reasonable and gurus will approve it i'll send disclaimer.
Comments:By: Clod Patry (junky) 2004-12-21 13:11:40.000-0600

for CVS Date or Stable Version field, please use a asterisk -V output.

And the patch won't be approved until you submit disclaimer, so please send it, and after we'll proceed your patch.

Thanks
By: Mark Spencer (markster) 2004-12-28 17:23:43.000-0600

Looks right except possibly some formatting.  Please use tabs instead of spaces and submit your disclaimer so we can continue processing.  Thanks.
By: gonzo gonzo (gonzo) 2005-01-05 15:54:03.000-0600

I have submitted disclaimer recently. Regarding space/tabs - i have just checked, there are tabs in patch.
By: Mark Spencer (markster) 2005-01-05 16:35:29.000-0600

Added to CVS, thanks!
By: Russell Bryant (russell) 2005-01-06 09:50:09.000-0600

issue does not appear to be present in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:20:07.000-0600

Repository: asterisk
Revision: 4684

U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r4684 | markster | 2008-01-15 15:20:06 -0600 (Tue, 15 Jan 2008) | 2 lines

Use ast_setcallerid instead of manual (bug ASTERISK-3057)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4684