Summary:ASTERISK-03055: [patch] hold/resume does not work anymore on cisco
Reporter:cherso (cherso)Labels:
Date Opened:2004-12-21 03:48:12.000-0600Date Closed:2008-01-15 15:17:53.000-0600
Versions:Frequency of
Environment:Attachments:( 0) hold_prob_12_6_working.txt
( 1) hold_prob_latest.txt
( 2) sipdebug_hold_and_resume_cvs-16-2_working.txt
( 3) sipdebug_hold_and_resume_latest_not_working.txt
( 4) siphold.txt
Description:updating to the latest CVS cisco 7960 Hold and Resume is not working on incoming calls. When you put on hold an incoming call you can't get it back. The callee is still hearing the music on hold.
cvs -D '15 days ago' is working
Comments:By: Olle Johansson (oej) 2004-12-21 04:51:31.000-0600

Always add a SIP debug when you report SIP problems (it's in the bug guidelines!), otherwise it's hard to analyze what is happening.

By: cherso (cherso) 2004-12-21 06:11:02.000-0600

hold_prob_latest is the log cap for the latest CVS
hold_prob_12_6 is the log cap cvs -D '15 days ago'
I'musing the same *.conf

Resuming the call the caller is still hearing the music on hold.
I can put on hold and resume correctly outgoing calls. The problem is just on incoming calls.

In the latest log you will see this.
Dec 20 14:15:16 DEBUG[2685]: Didn't get a frame from channel: SIP/2-936f
Dec 20 14:15:16 DEBUG[2685]: Bridge stops bridging channels SIP/2-936f and SIP/1-ae8c

if you need sip packets I will cap it next week

By: Clod Patry (junky) 2004-12-21 06:32:19.000-0600

When you report a bug, please use the field "CVS Date or Stable Version" to print the output of a show version output. (or asterisk -V, in shell).
It's there for that purpose.

You gonna post SIP debug next week? so why didnt wait next week to post the bug?
If you could post sip.conf and that part of your extensions.conf, that would be useful too.

I repeating this: faster you give us feed-backs, faster the bug will be fixed.Slower you gave us feed-backs, slower the bug will be fixed.

edited on: 12-21-04 06:34

By: cherso (cherso) 2004-12-21 06:41:39.000-0600

hold_prob_latest means latest CVS
12_6 is the CVS 12/6
dates are included in the hold*txt files

I was opening the bug thread just to let you know that an issue has been added in the CVS.
I will provide the sip debug log in about 1 hour ok?

By: cherso (cherso) 2004-12-21 08:09:52.000-0600

added complete sip debug.
Same call sip/9 to sip/1 -> answer-> sip/1 put it on hold and then resume

Sip/9 is outside behind a nat. Same problem calling from Sip/2 to Sip/1 with no nat in the middle

By: cherso (cherso) 2004-12-21 08:18:10.000-0600

latest CVS after
   -- Started music on hold, class 'default', on SIP/9-5242
SIP/2.0 200 OK
Contact: <sip:1@>

CVS 16/2
   -- Started music on hold, class 'default', on SIP/9-4a8e
Reliably Transmitting (no NAT):
SIP/2.0 200 OK
Contact: <sip:9@>

By: Kevin P. Fleming (kpfleming) 2004-12-22 01:10:46.000-0600

I can confirm this behavior on my system, using both 7940 and 7960 phones with 7.3 firmware. The problem does not occur on a Polycom IP 500.

I am trying to figure out what patches caused the problem... will post soon.

By: Kevin P. Fleming (kpfleming) 2004-12-22 01:18:21.000-0600

Reverting both patches from 2687 and 3087 cures the problem, although reverting them is a bit of a pain since there have been other changes since then...

Olle, please take a look at these traces :-)

By: Olle Johansson (oej) 2004-12-22 09:13:51.000-0600

See the problem...
* In the "not working" case, we are answering the re-invite with the wrong contact.
* In the working case, we are answering correctly, with our contact.

Now to code debugging, thank you for reporting this.

By: Olle Johansson (oej) 2004-12-22 11:14:06.000-0600

Patch for CVS head uploaded. Disclaimer on file.

I really wish we could take the whole SIP ACK away from stable until we solved the routing issue I've been mentioning in each bug report... Drumkilla: Find me on IRC to discuss this.

By: Olle Johansson (oej) 2004-12-22 11:14:39.000-0600

Patch tested and confirmed by kpfleming

By: Terry Wilson (twilson) 2004-12-22 12:31:36.000-0600

Seems to fix it on my test box as well.

By: Kevin P. Fleming (kpfleming) 2004-12-22 15:26:29.000-0600

Current patch "siphold.txt" applies cleanly to CVS HEAD and does solve the problem.

By: Mark Spencer (markster) 2004-12-22 20:19:07.000-0600

Fixed in CVS, thanks oej!

By: Digium Subversion (svnbot) 2008-01-15 15:17:53.000-0600

Repository: asterisk
Revision: 4532

U   trunk/channels/chan_sip.c

r4532 | markster | 2008-01-15 15:17:52 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix sip hold bug (ASTERISK-3055)