Summary: | ASTERISK-03030: [patch] Fix BYE for the SIP ack patch | ||
Reporter: | Olle Johansson (oej) | Labels: | |
Date Opened: | 2004-12-18 13:36:46.000-0600 | Date Closed: | 2008-01-15 15:17:23.000-0600 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_sip/Interoperability |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) sipack3.txt | |
Description: | Markster was fast in integrating the SIP ack patch, thank you. This patch fixes the problem with the BYE. Disclaimer on file. ****** ADDITIONAL INFORMATION ****** We still need to fix routing headers... Working on that. | ||
Comments: | By: Olle Johansson (oej) 2004-12-18 14:15:57.000-0600 Question to sort out: SHould Re-INVITEs be sent to the AOR or to the Contact URI? By: Olle Johansson (oej) 2004-12-18 14:19:23.000-0600 According to call flows in RFC 3665, re-invites should be sent to the Contact URI. Guess we have to fix that as well. By: Olle Johansson (oej) 2004-12-18 14:51:03.000-0600 New patch. I belive this solves re-invites as well as BYEs By: Mark Spencer (markster) 2004-12-18 17:02:07.000-0600 Fixed in CVS. Thanks :) The only reason I'm not adding karma is because, if I understand properly, this is a bug that was introduced from your earlier bug (and that would be a dangerous precedent). If I am mistaken let me know and I'll go add some for you! By: Russell Bryant (russell) 2004-12-19 20:52:20.000-0600 fixed in 1.0 By: Digium Subversion (svnbot) 2008-01-15 15:17:03.000-0600 Repository: asterisk Revision: 4478 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r4478 | markster | 2008-01-15 15:17:02 -0600 (Tue, 15 Jan 2008) | 2 lines Fix SIP ACK for BYE (bug ASTERISK-3030) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4478 By: Digium Subversion (svnbot) 2008-01-15 15:17:23.000-0600 Repository: asterisk Revision: 4500 U branches/v1-0/channels/chan_sip.c ------------------------------------------------------------------------ r4500 | russell | 2008-01-15 15:17:22 -0600 (Tue, 15 Jan 2008) | 2 lines Fix SIP ACK for BYE (bug ASTERISK-3030) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4500 |