| Summary: | ASTERISK-02995: mkdep script missing | ||
| Reporter: | jacs (jacs) | Labels: | |
| Date Opened: | 2004-12-15 04:33:54.000-0600 | Date Closed: | 2008-01-15 15:16:57.000-0600 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) DIFF.mkdep.txt | |
| Description: | just performed a fresh cvs install and the mkdep script is missing. | ||
| Comments: | By: Russell Bryant (russell) 2004-12-15 10:58:35.000-0600 I just did a fresh checkout and it was there. Feel free to re-open if you still think there is a problem. By: jacs (jacs) 2004-12-16 03:38:36.000-0600 Sorry my mistake it is there but it has been changed from a sh script to a bash script ie. < #!/bin/sh - --- > #!/bin/bash - This I think will break everyone other than linux as most other os's place bash in /usr/local/bin and is optional. I can't see why it needed to be changed. By: zoa (zoa) 2004-12-16 05:48:00.000-0600 i just checked, this was done for the solaris port... yesterday. Index: mkdep =================================================================== RCS file: /usr/cvsroot/libpri/mkdep,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- mkdep 29 Jun 2004 15:19:15 -0000 1.2 +++ mkdep 15 Dec 2004 20:15:28 -0000 1.3 @@ -1,4 +1,4 @@ -#!/bin/sh - +#!/bin/bash - # By: Mark Spencer (markster) 2004-12-16 09:16:53.000-0600 It does need to be bash. By: jacs (jacs) 2004-12-16 13:29:19.000-0600 How has this been resolved it breaks *bsd; as far as I can see its a straight shell script that has not changed in ages. Some resolution needs to be proposed for *bsd. By: jacs (jacs) 2004-12-16 13:32:45.000-0600 Oh and thanks for knocking 2 points off my karma. I spent some time finding out why CVS will not compile on *bsd and its been reported on the asterisk bsd list as well. By: Olle Johansson (oej) 2004-12-16 14:28:10.000-0600 markster: So bash is a new requirement for Asterisk? Are we sure that it is installed by default everywhere? On my FreeBSD systems, it's an add-on in /usr/local/bin If we require bash, we need to add that to docs. My shell scripting is kind of not refreshed - is it possible to check for a bangpath binary in several locations? By: tih (tih) 2004-12-17 00:50:47.000-0600 Under NetBSD, bash is also optional, and will be installed as /usr/pkg/bin/bash if you don't actively change the default configuration. Incidentally, the BSDs come with a working mkdep in /usr/bin. :-) By: tih (tih) 2004-12-17 01:09:41.000-0600 The fix is trivial. There's a modernism in the mkdep script that the Solaris /bin/sh doesn't support. Fixing that makes the script more portable. I'll upload the patch here. By: Mark Spencer (markster) 2004-12-17 03:03:13.000-0600 Fixed in CVS. I agree with the karma restoration as well. By: Russell Bryant (russell) 2004-12-17 09:47:44.000-0600 I'm sorry for the mixup. I wasn't able to fully understand your problem by the original bug report. By: Digium Subversion (svnbot) 2008-01-15 15:16:57.000-0600 Repository: asterisk Revision: 4471 U trunk/mkdep ------------------------------------------------------------------------ r4471 | markster | 2008-01-15 15:16:56 -0600 (Tue, 15 Jan 2008) | 2 lines Fix mkdep to work with /bin/sh on solaris and friends (bug ASTERISK-2995) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4471 | ||