[Home]

Summary:ASTERISK-02979: [patch] Move ast_app_has_voicemail and ast_app_messagecount to app_voicemail
Reporter:Jeffrey C. Ollie (jcollie)Labels:
Date Opened:2004-12-13 14:08:49.000-0600Date Closed:2008-01-15 15:19:10.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) movevmfunc.diff.txt
Description:This patch moves the bodies of ast_app_has_voicemail and ast_app_messagecount into app_voicemail.c and leaves behind stubs and some function pointers.  This keeps things more modular.  Once this patch gets accepted it will be possible to have the ast_app_messagecount and ast_app_has_voicemail work when using ODBC or other alternate storage.

****** ADDITIONAL INFORMATION ******

Disclaimer on file.
Comments:By: Mark Spencer (markster) 2004-12-13 14:36:33.000-0600

Should there be a function to register them?
By: Jeffrey C. Ollie (jcollie) 2004-12-13 14:51:13.000-0600

> Should there be a function to register them?

I can easily add one if you think it's necessary (like what was done in res_musiconhold) but the function pointers will get filled in by the load_module function in app_voicemail.
By: Jeffrey C. Ollie (jcollie) 2004-12-13 15:35:46.000-0600

Uploaded new version that uses a function in app.c to register the functions.
By: twisted (twisted) 2004-12-28 10:44:57.000-0600

Okay, so, markster, this bug's for you :)
By: Mark Spencer (markster) 2004-12-30 20:15:47.000-0600

Added to CVS.  There was one conflict but I left the change out anyway...  If we have a published interface, i guess we mind as well use it!
By: Russell Bryant (russell) 2005-01-03 12:05:41.000-0600

not in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:19:10.000-0600

Repository: asterisk
Revision: 4619

U   trunk/app.c
U   trunk/apps/app_voicemail.c
U   trunk/include/asterisk/app.h

------------------------------------------------------------------------
r4619 | markster | 2008-01-15 15:19:10 -0600 (Tue, 15 Jan 2008) | 2 lines

Make voicemail registration apps register (bug ASTERISK-2979)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4619