[Home]

Summary:ASTERISK-02943: [patch] noload'able res_musiconhold.so
Reporter:Anthony Minessale (anthm)Labels:
Date Opened:2004-12-08 17:59:53.000-0600Date Closed:2008-01-15 15:16:04.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_musiconhold
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) moh_register.diff
Description:This patch lets ast_moh_start/stop live in the core so
the symbols are available even without res_musiconhold.so
if the module is not loaded the ast_moh_start and stop will simply do nothing and warn you if verbose is 3 or higher.

See bug 2639 which also contains a version with this patch included. (that version if accepted would obselete this one)

****** ADDITIONAL INFORMATION ******

Disclaimer on file
anthmct@yahoo.com
Comments:By: Tilghman Lesher (tilghman) 2004-12-08 22:23:39.000-0600

Shouldn't the register and unregister functions be classname based, such that alternative modules can provide alternative sources of music?
By: Anthony Minessale (anthm) 2004-12-09 08:53:42.000-0600

If enough people agree, that is easily possible but it would require some changes to the configuration and the code since hense a big can of worms so I started by just making it possible to run asterisk with the music detached to
solve the catch22 of core depending on module ... (res_features is on that list too.)
By: Mark Spencer (markster) 2004-12-09 14:57:52.000-0600

Great idea.  In the future, please try to remember the following things, which will make my life much easier:

1) Please try to follow the existing coding style, specifically do:

int foo()
{
}

not:

int foo() {
}

when declaring functions, and:

if (foo) {
}

not
if (foo)
{
}

when calling other blocks.

Also, remember that option_verbose goes with ast_verbose, and should not add additional LOG_WARNING's...  Thanks!
By: Russell Bryant (russell) 2004-12-10 06:39:35.000-0600

not in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:16:04.000-0600

Repository: asterisk
Revision: 4411

U   trunk/channel.c
U   trunk/include/asterisk/musiconhold.h
U   trunk/res/res_musiconhold.c

------------------------------------------------------------------------
r4411 | markster | 2008-01-15 15:16:04 -0600 (Tue, 15 Jan 2008) | 2 lines

Make music on hold truly optional (bug ASTERISK-2943)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4411