Summary:ASTERISK-02924: [patch] H323 channel: in callback send_digit() argument call_token missing
Reporter:dg1nsw (dg1nsw)Labels:
Date Opened:2004-12-05 08:22:12.000-0600Date Closed:2011-06-07 14:10:45
Versions:Frequency of
Environment:Attachments:( 0) h323.patch
Description:When dialing digits on a softphone while connected to asterisk on the H323-channel the console prints the message

ERROR[245775]: chan_h323.c:1000 send_digit: Private structure not found in send_digit.

The callback function doesnt hand over the new 3rd parameter and the !=NULL check in find_call() fails.


Fixed in CVS allready!

The patch helped me but i am completely new to asterisk so dont blame me if its stupid :)
Comments:By: dg1nsw (dg1nsw) 2004-12-05 11:07:12.000-0600

I forgott the header file (channels/h323/chan_h323.c).
Should be in line 117

/* This is a callback prototype function, called pass
  DTMF down the RTP. */
typedef int (*send_digit_cb)(unsigned, const char, const char *token);
extern send_digit_cb    on_send_digit;

By: Brian West (bkw918) 2004-12-05 12:01:05.000-0600

naughty naughty you didn't read the bug guidlines.... Its not major if you can work around it... you did... you provided the fix... *tsk* *tsk*

Anyway good job. ;)

By: Andrey S Pankov (casper) 2004-12-10 03:30:14.000-0600

> Fixed in CVS allready!

Be careful here... chan_h323 is completely rewritten in CVS HEAD.
The bug you've reported was fixed in STABLE long ago before current stable 1.0.3 release.

By: Clod Patry (junky) 2004-12-21 00:21:54.000-0600

dg1nsw: can you confirm everythin goes well on your side, so we can close that bug/patch.
Thanks casper for remark.

By: dg1nsw (dg1nsw) 2004-12-21 15:31:58.000-0600

Yes. I didnt have problems with it. If my ok is enough then go ahead :)

By: Clod Patry (junky) 2004-12-21 22:35:19.000-0600

Like it's already fixed in CVS and everything goes well, im closing this one.
Re-open if necessery.