Summary: | ASTERISK-02892: [patch] missing ast_destroy(cfg) | ||
Reporter: | Belaid Arezqui (areski) | Labels: | |
Date Opened: | 2004-11-26 07:01:02.000-0600 | Date Closed: | 2008-01-15 15:15:22.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | CDR/cdr_pgsql |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) asterisk_cdr_pgsql.patch ( 1) asterisk_cdr_pgsql.patch.txt ( 2) markdiff.txt | |
Description: | To the file cdr/cdr_pgsql.c static int my_load_module(void) In case of an error, the ast_destroy(cfg) are missing! See patch in attachement. | ||
Comments: | By: Clod Patry (junky) 2004-11-26 17:12:25.000-0600 do ya've disclaimer on file? if not, please send it. For more info about it, please read http://www.digium.com/bugtracker.html Thanks. By: twisted (twisted) 2004-11-30 00:28:01.000-0600 New status update: CONFIRMED on patches means : "Ready for Commit" CONFIRMED on actual bugs means : "Able to Reproduce" (as it should be) ACKNOWLEDGED on patches means : We know about it, and are in the process of testing ACKNOWLEDGED on actual bugs means : We've acknowledged that it could be an issue. FEEDBACK as ALWAYS means, we need more feedback, and soon. By: Mark Spencer (markster) 2004-11-30 23:43:25.000-0600 Okay still waiting on a disclaimer to proceed By: twisted (twisted) 2004-11-30 23:47:01.000-0600 didn't think disclaimers were needed for trivial fixes/patches, which this appears to be. By: Brian West (bkw918) 2004-11-30 23:57:21.000-0600 Ok Ok so proper usage of ast_destroy needs a disclaimer? People that would claim copyright over that? oh wait its called SCO :P bkw By: Clod Patry (junky) 2004-11-30 23:59:18.000-0600 hehhee bkw, like i said to twisted, i'll tell him to send the disclaimer tomorrow. By: Mark Spencer (markster) 2004-12-01 00:28:52.000-0600 I just did my own, this one is a little cleaner looking too. By: Russell Bryant (russell) 2004-12-02 20:17:06.000-0600 fixed in 1.0 By: Digium Subversion (svnbot) 2008-01-15 15:15:22.000-0600 Repository: asterisk Revision: 4365 U trunk/cdr/cdr_pgsql.c ------------------------------------------------------------------------ r4365 | markster | 2008-01-15 15:15:22 -0600 (Tue, 15 Jan 2008) | 2 lines Fix missing ast_destroy's in PGSQL (bug ASTERISK-2892) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4365 |