Summary:ASTERISK-02840: [patch] [v1-0] Backport locking changes from CVS HEAD + formating/spacing
Reporter:Andrey S Pankov (casper)Labels:
Date Opened:2004-11-17 07:45:31.000-0600Date Closed:2011-06-07 14:04:49
Versions:Frequency of
Environment:Attachments:( 0) MERGE_HEAD.diff.txt
( 1) V1-0_MERGE.diff.txt
Description:It would be nice if someone else try them on stable v1-0 and report success/failure (BTW, this works for me).


Disclaimer is on file at Digium.
Comments:By: Andrey S Pankov (casper) 2004-11-18 07:46:11.000-0600

V1-0_MERGE.diff.txt - patch to apply against today's v1-0 CVS

MERGE_HEAD.diff.txt - diff of today's CVS HEAD and chan_mgcp _after_ V1-0_MERGE.diff.txt patch applied (this is to prove that after you apply it differences will be only HEAD specific [callerid rework, voicemail multiple folders, transfer within agent, status back]).

The only small difference is in mgcp_hangup. I'd suggest to ast_mutex_lock(&sub->lock) a bit earlier (_before_ referencing "sub" in the code, not _after_ ast_dsp_free [as e.g. per chan_sip sources]).

markster: Why not to apply this little fix to CVS HEAD? Patch is not included, sorry, it's too trivial to code in...

By: Andrey S Pankov (casper) 2004-11-18 07:53:08.000-0600

Sorry again for not including several formatting/spacing cleanups (diffs are both -ub).

I've made it explicitly to facilitate understanding of what is being fixed. Please try and report. Thanks!

By: litw (litw) 2004-11-18 11:45:55.000-0600

casper, what mgcp devices do you use ?

By: Andrey S Pankov (casper) 2004-11-19 04:31:45.000-0600

My email is casper at casper dot org dot ua
ICQ UIN 81533044 (Casper)
Feel free to contact me if you have any questions. :)

By: Pavel Litvinenko (pavell) 2004-11-24 05:45:47.000-0600

works with asterisk 1.0.2
... but with devices  on the loosy links channels was stopped send/receive packets  at all several times.

By: Andrey S Pankov (casper) 2004-12-03 08:13:10.000-0600

Please do not use this patch in production, this is still work in progress [in CVS HEAD].

By: twisted (twisted) 2004-12-15 20:52:22.000-0600

I'm unsure what's going on here... how can this be a backport to stable when it's a WIP on HEAD?


By: Andrey S Pankov (casper) 2004-12-16 09:14:29.000-0600

There are known issues with this code in CVS HEAD not resolved yet (e.g. ASTERISK-2889)

But this patch is for people who wants to try new chan_mgcp code but unable/fails to backport changes form HEAD to v1-0.

By: Andrey S Pankov (casper) 2004-12-29 09:29:06.000-0600

Please close this bug since the patch is out-of-date for now and I don't have any intention to maintain it any longer.

edited on: 12-29-04 09:43

By: twisted (twisted) 2004-12-29 18:31:28.000-0600

Closed per poster