[Home]

Summary:ASTERISK-02839: [patch] fix UK CallerID on outward FXS port
Reporter:marty (marty)Labels:
Date Opened:2004-11-17 07:41:53.000-0600Date Closed:2008-01-15 15:19:01.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_zap.c.HEAD.patch
( 1) chan_zap.c.patch
( 2) zapata.conf.sample.patch
Description:CallerID generated on an outgoing FXS port (to the handset) fails when UK tones are used, with a message 'Didn't finish Caller-ID spill.  Cancelling.'

I'd like to expose 'DEFAULT_CIDRINGS' as an option, rather than a #define in chan_zap.c


****** ADDITIONAL INFORMATION ******

In chan_zap.c, there is a '#define DEFAULT_CIDRINGS 1' which looks like it detemines when the CallerID is sent. My assumption is that the UK has a 'dual ring' tone, instead of the single tone used in the US. If we send after the first ring, the second part of the dual tone collides and the caller id is cancelled.

Changing the tones to US style avoids the problem, so it is something to do with the UK tones.

I would like to open this #define up as a configuration option in the chan_zap.c file, as hardcoding it makes it very inflexible.

If someone agrees, I'll knock up the patch.
Comments:By: marty (marty) 2004-11-17 13:54:49.000-0600

Added patches for stable (1.0.2) and CVS Head (from today, 17/11/2004) and also for the zapata.conf.sample file.

Without this, the chan_zap.c file needs manually updating and re-compiling in order for FXS ports to work with the uk tones and outgoing callerid.
By: Mark Spencer (markster) 2004-12-04 19:25:25.000-0600

oops i accidently deleted a file while reading this bug, i hope it wasn't important!
By: marty (marty) 2004-12-05 10:18:57.000-0600

Re-uploaded the file; it's useful to me in the UK, as without it, I don't get caller id on FXS ports. Unless that is, I'm prepared to go in and tweak a #define and change the settings of all FXS ports and re-compile asterisk.

The patch exposes the #define setting, so it can be controlled by a config file.

In production for over a month now with no user complaints!

m
By: twisted (twisted) 2004-12-15 20:57:46.000-0600

Let's get the attention of the markster again ;)
By: twisted (twisted) 2004-12-15 20:58:06.000-0600

also, we need to make sure the head patch still applies and works on current head.
By: Mark Spencer (markster) 2004-12-28 16:35:57.000-0600

Just need confirmation of a disclaimer to merge this.  Thanks!
By: Mark Spencer (markster) 2004-12-28 16:37:18.000-0600

Nevermind i found it in another bug report.  Thanks!
By: Russell Bryant (russell) 2004-12-30 15:42:40.000-0600

added to 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:18:29.000-0600

Repository: asterisk
Revision: 4574

U   trunk/channels/chan_zap.c
U   trunk/configs/zapata.conf.sample

------------------------------------------------------------------------
r4574 | markster | 2008-01-15 15:18:29 -0600 (Tue, 15 Jan 2008) | 2 lines

Make cidrings configurable (bug ASTERISK-2839)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4574
By: Digium Subversion (svnbot) 2008-01-15 15:19:01.000-0600

Repository: asterisk
Revision: 4608

U   branches/v1-0/channels/chan_zap.c
U   branches/v1-0/configs/zapata.conf.sample

------------------------------------------------------------------------
r4608 | russell | 2008-01-15 15:19:00 -0600 (Tue, 15 Jan 2008) | 2 lines

make cid rings configurable (bug ASTERISK-2839)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4608