[Home]

Summary:ASTERISK-02834: CVS 1-0 and 1-0-2 mismatch (libpri features/function)
Reporter:cmaj (cmaj)Labels:
Date Opened:2004-11-16 14:30:17.000-0600Date Closed:2004-11-17 22:27:13.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:I really want to use the backup D-Channels, and the configurable timers would be nice too, but a CVS checkout of libpri v1-0 does not give you these features.  However, it is available with v1-0-2 and current.

This is different than what's happening in the asterisk module.  There, a checkout of v1-0 will give you everything in v1-0-2 and the stuff submitted on the way to v1-0-3.  I think this is what one would expect and it also follows the directions on the web page, which is probably where most people get their CVS info from.  I think it's working the same way for the zaptel module.  Apparently, the libpri module is the only one off balance.

Let me say that I hate CVS just as much as the next person, and I have no idea how to fix this problem.  It was just irritating when I checked out 1-0 for all three modules and I got 1-0-0 libpri, and 1-0-2+ asterisk and zaptel.


****** ADDITIONAL INFORMATION ******

Kudos to all for putting together a stable branch.
Comments:By: Russell Bryant (russell) 2004-11-16 16:33:14.000-0600

I just did a 'cvs checkout -r v1-0 libpri' and diff'd it against my stable libpri directory that I work from and there was no difference.
By: Russell Bryant (russell) 2004-11-17 20:13:00.000-0600

yeahhh ... I just downloaded the 1.0.2 tarball and I don't see any problems.

Try this again:

cvs checkout -r v1-0 libpri
By: cmaj (cmaj) 2004-11-17 20:39:14.000-0600

This is what I get from a fresh "cvs checkout -r v1-0 libpri":

-rw-r--r--    1 chris    chris         415 Oct 29 10:12 ChangeLog
-rw-r--r--    1 chris    chris       18008 Oct 14 19:04 LICENSE
-rw-r--r--    1 chris    chris        3490 Aug 31 13:40 Makefile
-rw-r--r--    1 chris    chris        1464 Oct 14 19:04 README
-rw-r--r--    1 chris    chris         167 May 12  2001 TODO
-rw-r--r--    1 chris    chris       17862 Oct 27 10:45 libpri.h
-rwxr-xr-x    1 chris    chris        3152 Jun 29 11:19 mkdep
-rw-r--r--    1 chris    chris       12367 Oct 27 10:45 pri.c
-rw-r--r--    1 chris    chris        3607 Jun 26 00:37 pri_internal.h
-rw-r--r--    1 chris    chris        5360 Oct 29 10:12 pri_q921.h
-rw-r--r--    1 chris    chris        8321 Jun 16 11:33 pri_q931.h
-rw-r--r--    1 chris    chris        3276 May 22 00:25 pridump.c
-rw-r--r--    1 chris    chris        3189 Jun  5 02:50 prisched.c
-rw-r--r--    1 chris    chris        9597 Jun  5 02:50 pritest.c
-rw-r--r--    1 chris    chris       25531 Jul 23 12:04 q921.c
-rw-r--r--    1 chris    chris       93094 Oct  4 22:19 q931.c
-rw-r--r--    1 chris    chris        5180 May 22 00:25 testprilib.c


Here's what I get from a fresh "cvs checkout -r v1-0-0 libpri":

-rw-r--r--    1 chris    chris         373 Mar 22  2002 ChangeLog
-rw-r--r--    1 chris    chris        3490 Aug 31 13:40 Makefile
-rw-r--r--    1 chris    chris        1419 May 12  2001 README
-rw-r--r--    1 chris    chris         167 May 12  2001 TODO
-rw-r--r--    1 chris    chris       17853 Sep 17 00:02 libpri.h
-rwxr-xr-x    1 chris    chris        3152 Jun 29 11:19 mkdep
-rw-r--r--    1 chris    chris       12121 Jun 29 13:57 pri.c
-rw-r--r--    1 chris    chris        3607 Jun 26 00:37 pri_internal.h
-rw-r--r--    1 chris    chris        5255 Jun  5 02:50 pri_q921.h
-rw-r--r--    1 chris    chris        8321 Jun 16 11:33 pri_q931.h
-rw-r--r--    1 chris    chris        3276 May 22 00:25 pridump.c
-rw-r--r--    1 chris    chris        3189 Jun  5 02:50 prisched.c
-rw-r--r--    1 chris    chris        9597 Jun  5 02:50 pritest.c
-rw-r--r--    1 chris    chris       25531 Jul 23 12:04 q921.c
-rw-r--r--    1 chris    chris       93037 Sep 20 09:29 q931.c
-rw-r--r--    1 chris    chris        5180 May 22 00:25 testprilib.c


And this is what I get from a fresh "cvs checkout -r v1-0-2 libpri":

-rw-r--r--    1 chris    chris         373 Mar 22  2002 ChangeLog
-rw-r--r--    1 chris    chris       18008 Oct 14 14:23 LICENSE
-rw-r--r--    1 chris    chris        3490 Aug 31 13:40 Makefile
-rw-r--r--    1 chris    chris        1464 Oct 14 14:23 README
-rw-r--r--    1 chris    chris         167 May 12  2001 TODO
-rw-r--r--    1 chris    chris       19544 Oct  2 10:55 libpri.h
-rwxr-xr-x    1 chris    chris        3152 Jun 29 11:19 mkdep
-rw-r--r--    1 chris    chris       14838 Oct  2 10:55 pri.c
-rw-r--r--    1 chris    chris        3683 Oct  2 10:55 pri_internal.h
-rw-r--r--    1 chris    chris        5110 Oct  2 10:55 pri_q921.h
-rw-r--r--    1 chris    chris        8321 Jun 16 11:33 pri_q931.h
-rw-r--r--    1 chris    chris        2446 Oct  2 10:55 pri_timers.h
-rw-r--r--    1 chris    chris        3276 May 22 00:25 pridump.c
-rw-r--r--    1 chris    chris        3189 Jun  5 02:50 prisched.c
-rw-r--r--    1 chris    chris        9597 Jun  5 02:50 pritest.c
-rw-r--r--    1 chris    chris       25818 Oct  2 10:55 q921.c
-rw-r--r--    1 chris    chris       93117 Oct  4 10:41 q931.c
-rw-r--r--    1 chris    chris        5180 May 22 00:25 testprilib.c



The LICENSE file is the only difference between 1-0 and 1-0-0, while 1-0-2 adds pri_timers.h, but 1-0-2 is different that 1-0.  This is all from anonymous CVS and not any tarballs, with CVSROOT=:pserver:anoncvs@cvs.digium.com:/usr/cvsroot

edited on: 11-17-04 20:41

edited on: 11-17-04 20:42
By: Russell Bryant (russell) 2004-11-17 22:21:29.000-0600

Ok, so, it looks like the tag is wrong.  If you download the tarball, you get the correct release.  When you get the v1-0-2 tag from CVS, you get some features from CVS head.

Sorry about that.

Just use v1-0 for the latest stable code.  If you want to use any of the new feautres, use CVS head.
By: Russell Bryant (russell) 2004-11-17 22:27:02.000-0600

I'll look into how to fix the tag.