Summary:ASTERISK-02830: [patch] app_dial use of dial options disallows unlimited timeout without warning.
Reporter:zoa (zoa)Labels:
Date Opened:2004-11-16 07:15:13.000-0600Date Closed:2011-06-07 14:10:19
Versions:Frequency of
Environment:Attachments:( 0) app_dial_timeout_patch.diff.txt
Description:If you try to use any options, you must specify a valid timeout parameter value, -1 (the default timeout) will result in a warning.

This micro-patch allows -1 as valid timeout value.


Standard Dial has no timeout, however when you use an option, you need to set a timeout, and unlimited is not a valid option.

Comments:By: zoa (zoa) 2004-11-16 07:24:44.000-0600

Disclaimer faxed as Vanheuverzwijn Joachim.

By: zoa (zoa) 2004-11-16 07:31:59.000-0600

Please note that im not talking about the S(X) absolute talking timeout.

By: twisted (twisted) 2004-11-17 22:55:46.000-0600

I don't understand... Are you referring to the field I have conveniently marked with an 'x'?

exten => 1234,1,Dial(IAX2/someplace/44444,x,Tr)


If so, I haven't received any warnings by leaving this field blank, and just doing double ,,'s or ||'s.

By: twisted (twisted) 2004-11-17 22:57:39.000-0600

A better solution in my opinion would be to check to see if the value in the timeout field is actually numerical, and if not, just disrgard and pass it off to the options..   see isdigit() as an example of how to do this.

By: zoa (zoa) 2004-11-18 15:57:47.000-0600

hmm, we could actually leave an emply space indeed.
never thought about that when my collegue came with this problem. (only tried 0 and -1 then looked at the source)

although -1 should be valid, we can easily work around this by not putting anything at all.