[Home]

Summary:ASTERISK-02774: [patch] clean up a bit in chan_sip
Reporter:Brian West (bkw918)Labels:
Date Opened:2004-11-09 14:30:41.000-0600Date Closed:2008-01-15 15:13:10.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_sip.diff.txt
Description:Here, disclaimer on file.
Comments:By: Brian West (bkw918) 2004-11-09 14:39:25.000-0600

fixed the tabs vs. spaces
By: Mark Spencer (markster) 2004-11-09 16:54:06.000-0600

Even the patched version is much worse.  Things should look like:

if (foo) {
    bar;
}
By: Mark Spencer (markster) 2004-11-10 15:53:16.000-0600

Any interest left?
By: Brian West (bkw918) 2004-11-10 18:57:00.000-0600

There ya go...
By: Mark Spencer (markster) 2004-11-10 20:21:47.000-0600

Why are you losing the else before the if's?
By: Mark Spencer (markster) 2004-11-11 10:07:46.000-0600

Fixed in CVS (slightly different patch)
By: Russell Bryant (russell) 2004-11-12 09:16:07.000-0600

not in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:13:10.000-0600

Repository: asterisk
Revision: 4203

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r4203 | markster | 2008-01-15 15:13:09 -0600 (Tue, 15 Jan 2008) | 2 lines

Cleanup/performance improve chan_sip slightly (bug ASTERISK-2774)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4203