Summary:ASTERISK-02773: [patch] Support for Note2 Table 4-3/Q.931 (some information elements may be repeated)
Reporter:Paul Cadach (pcadach)Labels:
Date Opened:2004-11-09 12:56:08.000-0600Date Closed:2005-01-17 15:00:15.000-0600
Versions:Frequency of
Environment:Attachments:( 0) libpri-newprogress.diff
( 1) libpri-newprogress.diff
( 2) libpri-newprogress.diff
( 3) libpri-newprogress.diff
Description:Because switches sends multiple progress indicator IE (for example, indicating called party is not ISDN and call progress information available in-band), to not loose information about a call, libpri requires feature that stores all progress indicators. Best way to do so is to convert individual values into bitmasks and back.


Disclaimer is on file.

This patch also slightly fixes formatting at libpri.h and q931.c.
Comments:By: Paul Cadach (pcadach) 2004-11-11 00:10:03.000-0600

Updated after discussion with Mark. Formatting is get back to tab size = 4, progress field is renamed to progressmask, PRI_PROGRESS_MASK defined to distinct new progress code from old one.

By: Paul Cadach (pcadach) 2004-11-17 12:31:39.000-0600

Updated as suggested by Mark, but keeping handling of old progress field is a "dust" IMHO.

By: Olle Johansson (oej) 2004-12-12 15:56:15.000-0600

Does this patch still apply to CVS? Will it be included? Status update, please!


By: Paul Cadach (pcadach) 2004-12-21 12:36:11.000-0600

Patch is updated for the current CVS (around 2004-12-21 12:00:00 GMT-6).

By: Mark Spencer (markster) 2005-01-05 21:11:15.000-0600

I'm still concerned greatly about the backwards compatibility implications of this patch.  Generally speaking, libpri has been backwards source compatible and mostly binary compatible, but this patch clearly breaks that.

By: Paul Cadach (pcadach) 2005-01-06 01:01:23.000-0600

Latest patch (dated 12-21-04) slightly outdated but provides binary compatibility (there is two fields:
1) progress which holds LAST progress indicator value (as it was before);
2) progressmask which holds bitmask of ALL progress indicators.
Also, existing API isn't allows to specify progress indicator value directly, so transmission part isn't broken. Other IE stuff is backward-compatible too.

By: Mark Spencer (markster) 2005-01-06 01:15:48.000-0600

Doesn't seem to quite apply to CVS anymore.  Can we move the "max_count" argument to later in the structure so the table looks more similar?  Other than that (and actually applying to latest CVS) I think i'm willing to give it a go. Thanks!

By: Paul Cadach (pcadach) 2005-01-09 12:24:59.000-0600

Updated to the current CVS.

By: Paul Cadach (pcadach) 2005-01-17 06:18:02.000-0600

Still cleanly applies to the current CVS.

By: Mark Spencer (markster) 2005-01-17 06:54:49.000-0600

Added to CVS head.  Thanks!