[Home]

Summary:ASTERISK-02765: [patch] Add timezone support for IAX date/time Information Element
Reporter:Russell Bryant (russell)Labels:
Date Opened:2004-11-08 12:58:32.000-0600Date Closed:2008-01-15 15:13:00.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) iax-timezones.txt
Description:This patch allows you to set time zones for peers.  This will be reflected in the value of the date/time Information Element.

This patch also includes some formatting fixes.

****** ADDITIONAL INFORMATION ******

Disclaimer is on file.
Comments:By: Brian West (bkw918) 2004-11-08 17:01:59.000-0600

now do one to pass the chan_iax2 cvs revision in an IE also. :) helps in debugging.

bkw
By: Brian West (bkw918) 2004-11-08 17:02:16.000-0600

oh forgot PLEASE PLEASE PLEASE!!! ;)
By: ckruetze (ckruetze) 2004-11-08 19:05:31.000-0600

Thanks, for this patch.
However, might it not be better to somehow let the peers set there own time zone? What if they move to another time zone?

Also some form of standard would be useful, otherwise it might get complicated for 3rd party programms/addons, if some people use "Eastern Daylight Time" while others just "EDT".
By: Russell Bryant (russell) 2004-11-08 23:57:15.000-0600

> However, might it not be better to somehow let the peers set there own time zone? What if they move to another time zone?

If you are concerned about this case, you can set it to GMT or leave it as the server's localtime.  The SIP spec doesn't even allow for this option.  It states that the time *must* be given in GMT.

> Also some form of standard would be useful, otherwise it might get complicated for 3rd party programms/addons, if some people use "Eastern Daylight Time" while others just "EDT".

Well, the standard that is there is that it has to be a valid path in /usr/share/zoneinfo.  For Eastern time, "America/New_York" and "EST5EDT" would be valid, as well as some others, I'm sure.
By: Mark Spencer (markster) 2004-11-09 00:04:08.000-0600

Added to CVS, thanks!
By: Russell Bryant (russell) 2004-11-09 00:13:20.000-0600

yay

not included in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:13:00.000-0600

Repository: asterisk
Revision: 4191

U   trunk/channels/chan_iax2.c
U   trunk/configs/iax.conf.sample

------------------------------------------------------------------------
r4191 | markster | 2008-01-15 15:13:00 -0600 (Tue, 15 Jan 2008) | 2 lines

Make timezone configurable within IAX (bug ASTERISK-2765)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4191