Summary: | ASTERISK-02764: Supervised transfer will result into called party hearing moh | ||
Reporter: | Matteo Brancaleoni (mbrancaleoni) | Labels: | |
Date Opened: | 2004-11-08 11:19:48.000-0600 | Date Closed: | 2008-01-15 15:13:03.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_sip/Transfers |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) chan_sip.patch | |
Description: | Supervised transfer will result into called party hearing moh: A(any tech) calls B(sip) B(sip) calls C(any tech) (A hears moh now) B(sip) transfers to C(any tech) now B hears C, C can speak but hears moh Searching and tracing, I noticed that (as per rfc standards) the last invite is sent with a=sendonly in sdp payload. That issue makes asterisk starts moh on C, since it will start moh always if the channel is bridged and sees a=sendonly into sdp. so, there're 2 ways to solve that: * when starting moh in process_sdp, check if we're on a transfer and don't start it on C * in attempt_transfer exec ast_quiet_chan also on C I have followed the 2nd way, but dunno if is the correct way, since moh is started and stopped in a short time. if interested, I can put the ugly patch. but can discuss on that. | ||
Comments: | By: Matteo Brancaleoni (mbrancaleoni) 2004-11-08 11:35:00.000-0600 I uploaded the ugly(tm) patch. lemme know what do you think. By: Paul Cadach (pcadach) 2004-11-08 12:54:52.000-0600 Is this works for 2 transfer points: 1) A calls B, B calls C, C calls D, C transfers to D, B transfers to C; 2) A calls B, B calls C, B transfers to C; C calls D; C transfers to D? By: Mark Spencer (markster) 2004-11-08 13:21:43.000-0600 Fixed in CVS head. I was actually *just* talking to someone about this issue on the phone when you placed your report. How bizarre. By: Russell Bryant (russell) 2004-11-09 00:27:16.000-0600 fixed in 1.0 - will be in 1.0.3 By: Digium Subversion (svnbot) 2008-01-15 15:12:59.000-0600 Repository: asterisk Revision: 4189 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r4189 | markster | 2008-01-15 15:12:58 -0600 (Tue, 15 Jan 2008) | 2 lines Fix supervised transfer (bug ASTERISK-2764) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4189 By: Digium Subversion (svnbot) 2008-01-15 15:13:03.000-0600 Repository: asterisk Revision: 4194 U branches/v1-0/channels/chan_sip.c ------------------------------------------------------------------------ r4194 | russell | 2008-01-15 15:13:02 -0600 (Tue, 15 Jan 2008) | 2 lines Fix supervised transfer (bug ASTERISK-2764) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4194 |