Summary:	ASTERISK-02741: compilation error in chan_h323 in 1.0.2 stable version
Reporter:	lvazquez (lvazquez)	Labels:
Date Opened:	2004-11-04 13:16:29.000-0600	Date Closed:	2004-11-04 17:52:12.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-1.0.2-h323_send_digit.patch
Description:	There's a bug in the chan_h323.h and ast_h323.c in stable version 1.0.2 which will prevent compiling asterisk with h323 support. ######################################## ast_h323.cpp: In member function `void MyH323Connection::SendUserInputTone(char, unsigned int)': ast_h323.cpp:725: error: invalid conversion from `char' to `const char*' ast_h323.cpp: In member function `virtual void MyH323Connection::OnUserInputTone(char, unsigned int, unsigned int, unsigned int)': ast_h323.cpp:735: error: invalid conversion from `char' to `const char*' ast_h323.cpp: In member function `virtual void MyH323Connection::OnUserInputString(const PString&)': ast_h323.cpp:746: error: invalid conversion from `char' to `const char*' #################################### The function pointer data type send_digit_cb and the send_digit_cb variable is defined in h323/chan_h323.h:117 as: typedef int (*send_digit_cb)(unsigned, const char *); extern send_digit_cb on_send_digit; and this this is used in h323/ast_h323.c to assign the funcion send_digit() defined in chan_h323.c with a diferent signature: ....... int send_digit(unsigned call_reference, char digit, const char *token) { ..... So the type of send_digit_cb should be: .... typedef int (*send_digit_cb)(unsigned, char, const char *); .... Comparing with the calls to on_answer_call() it seems an extra parameter (const char *)GetCallToken() should be added to on_send_digit() in ast_h323.c Looking the cvs (stable branch) history I found this change was introduced in h323/chan_h323.h from r1.27 to r1.28. I checked both the asterisk-1.0.2.tar.gz from digium download and the stable CVS (cvs co -r v1-0-2 asterisk) and both have the same problem ****** ADDITIONAL INFORMATION ****** I do include a patch that seems to fix it.
Comments:	By: lvazquez (lvazquez) 2004-11-04 13:46:51.000-0600 Ouch, this problem/bug is the same as reported in 2669 and 2786 (Yes I know, I should have chequed previous reports before, but...) Also my patch/fix seems to be the same as the one posted in 2669 (so it must be ok :) When is this going to be included in stable cvs branch? By: Brian West (bkw918) 2004-11-04 17:37:00.000-0600 Then post your patch to 2669.  Do not open a new bug it causes distraction from the real problem. bkw