[Home]

Summary:ASTERISK-02733: [patch] German syntax for say.c and it's neighborhood; Creation of say_enumeration (1st,2nd,...,101st,...,last)
Reporter:Frank Sautter (xylome)Labels:
Date Opened:2004-11-03 07:44:09.000-0600Date Closed:2008-01-15 15:13:30.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/Internationalization
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) german-say-patch.txt
( 1) german-say-patch-1.40.txt
( 2) german-say-patch-1.40-2.txt
( 3) german-say-patch-1.41.txt
( 4) german-say-patch-1.42.txt
Description:say.c
* correct german syntax for say_number_full_de
* creation of say_time_de
* creation of say_date_de
* creation of say_datetime_de
* creation of say_enumeration, say_enumeration_full[|_de|_en] useful for dates and voicemail. says (1st,2nd,3rd,..,31st,...,101st,...,last). last is said when called with INT_MAX.
* neagtive numbers for say_number_full_[cz|da|de|en|es|fr|it|nl|pt|se|tw]
* some whitespace cleanup according to coding guidelines

apps/app_sayunixtime.c
* german support for sayunixtime_exec

apps/app_voicemail.c
* german support for play_message_datetime

the patch works against this file versions
say.c ver. 1.39 (CVS-HEAD on 2004-11-03)
asterisk/include/say.h ver. 1.10 (CVS-HEAD on 2004-11-03)
apps/app_sayunixtime.c ver. 1.6 (CVS-HEAD on 2004-11-03)
apps/app_voicemail.c ver. 1.151 (CVS-v1-0-1 on 2004-11-03)

****** ADDITIONAL INFORMATION ******

for enumeration and negative numbers this .gsm files are needed (they are already available through the asterisk-sound cvs-project)
digits-h-minus.gsm
digits/h-40.gsm
digits/h-50.gsm
digits/h-60.gsm
digits/h-70.gsm
digits/h-80.gsm
digits/h-90.gsm
digits/h-hundred.gsm
digits/h-thousand.gsm
digits/h-million.gsm
digits/h-last.gsm
####
a set of compatible german sounds will follow soon
####
disclaimer was signed on 2004-10-21
Comments:By: Frank Sautter (xylome) 2004-11-03 13:15:35.000-0600

i just added a new patch file against version 1.40 of say.c (CVS-HEAD on 2004-11-03)

bearbeitet am: 11-05-04 07:08
By: Olle Johansson (oej) 2004-11-03 13:41:57.000-0600

Please remove "//" comments (say.h) - they do not follow our coding guidelines.

Is the change to the .cvsignore file accidental?

/O
By: Frank Sautter (xylome) 2004-11-05 07:07:00.000-0600

removed "//" comments
patch "german-say-patch-1.40-2.txt" now works against:
* say.c ver. 1.40 (CVS-HEAD on 2004-11-05)
* asterisk/include/say.h ver. 1.10 (CVS-HEAD on 2004-11-05)
* apps/app_sayunixtime.c ver. 1.6 (CVS-HEAD on 2004-11-05)
* apps/app_voicemail.c ver. 1.151.2.4 (CVS-v1-0-2 on 2004-11-05)

the changes to app_voicemail.c are only two new lines and can be implemented manually on HEAD-version of app_voicemail.c if necessary.
By: Frank Sautter (xylome) 2004-11-10 06:49:02.000-0600

as there is a new version of say.c in the CVS-HEAD.... a new patch (and some code cosmetics)

patch "german-say-patch-1.41.txt" now works against:
* say.c ver. 1.41 (CVS-HEAD on 2004-11-10)
* asterisk/include/say.h ver. 1.10 (CVS-HEAD on 2004-11-10)
* apps/app_sayunixtime.c ver. 1.6 (CVS-HEAD on 2004-11-10)
* apps/app_voicemail.c ver. 1.151.2.4 (CVS-v1-0-2 on 2004-11-05)

the changes to app_voicemail.c are only two new lines and so they can easily be implemented manually on HEAD-version of app_voicemail.c if necessary.
By: Frank Sautter (xylome) 2004-11-12 03:40:51.000-0600

Hello bug marshals out there... it would be nice if someone could include this patch to CVS-HEAD soon, as this is a rather big patch and code cleanup and therefore it is very time consuming (and maybe error prone) to merge this patch against those small patches appearing every other day.
i will do my best in supporting a bug marshal if there should be any questions.

as there is a new version of say.c in the CVS-HEAD.... a new patch (and some more code cosmetics)

patch "german-say-patch-1.42.txt" now works against:
* say.c ver. 1.42 (CVS-HEAD on 2004-11-12)
* asterisk/include/say.h ver. 1.10 (CVS-HEAD on 2004-11-12)
* apps/app_sayunixtime.c ver. 1.6 (CVS-HEAD on 2004-11-12)
* apps/app_voicemail.c ver. 1.151.2.4 (CVS-v1-0-2 on 2004-11-05)
the changes to app_voicemail.c can be omitted. they are only two new lines and so they can easily be implemented manually on HEAD-version of app_voicemail.c if necessary.
By: Mark Spencer (markster) 2004-11-12 08:49:54.000-0600

I have it merged at home but it won't go in until i finish the rest of my changes to make it all const char *
By: Mark Spencer (markster) 2004-11-13 11:12:07.000-0600

Merged in CVS head.  Thanks!
By: Russell Bryant (russell) 2004-11-14 21:22:21.000-0600

No new features will be going into stable.  If there is something in the 1.0 branch that doesn't work correctly, please submit a patch that addresses that issue directly.

Thank you!
By: Digium Subversion (svnbot) 2008-01-15 15:13:30.000-0600

Repository: asterisk
Revision: 4229

U   trunk/apps/app_sayunixtime.c
U   trunk/apps/app_voicemail.c
U   trunk/channels/chan_iax2.c
U   trunk/file.c
U   trunk/formats/format_g723.c
U   trunk/formats/format_g726.c
U   trunk/formats/format_g729.c
U   trunk/formats/format_gsm.c
U   trunk/formats/format_h263.c
U   trunk/formats/format_ilbc.c
U   trunk/formats/format_pcm.c
U   trunk/formats/format_pcm_alaw.c
U   trunk/formats/format_sln.c
U   trunk/formats/format_vox.c
U   trunk/formats/format_wav.c
U   trunk/formats/format_wav_gsm.c
U   trunk/include/asterisk/file.h
U   trunk/include/asterisk/say.h
U   trunk/say.c

------------------------------------------------------------------------
r4229 | markster | 2008-01-15 15:13:30 -0600 (Tue, 15 Jan 2008) | 2 lines

Updates from char * to const char * + german syntax + enumeration (bug ASTERISK-2733)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4229