[Home]

Summary:ASTERISK-02708: [patch] make table name for "cdr" table configurable in cdr_odbc and cdr_odbc module unloadable
Reporter:Andrey S Pankov (casper)Labels:
Date Opened:2004-10-30 05:25:02Date Closed:2008-01-15 15:16:09.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:CDR/cdr_odbc
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) cdr_odbc.c.diff.txt
( 1) cdr_odbc.c.diff.txt
( 2) cdr_odbc.c.diff.txt
( 3) cdr_odbc.c.diff.txt
( 4) cdr_odbc.c.diff.txt
( 5) cdr_odbc.conf.sample.diff.txt
Description:At the moment the table name ("cdr") for the cdr's is
hardcoded in cdr_odbc. It might be a good idea to make
that configurable.
cdr_odbc module is not unloadable because of usecount always returning connection state.
Comments:By: Andrey S Pankov (casper) 2004-10-30 05:25:46

Disclaimer is on file at Digium.
By: Brian West (bkw918) 2004-10-30 11:11:48

//return connected;  << remove that.

bkw
By: Andrey S Pankov (casper) 2004-10-31 14:46:56.000-0600

done.
By: duanecox (duanecox) 2004-11-01 14:46:18.000-0600

how about one for cdr_tds.c ?
By: Russell Bryant (russell) 2004-11-14 21:55:56.000-0600

any updates here?  Is this ready for commit?

-- Housekeeping
By: Andrey S Pankov (casper) 2004-11-15 05:20:09.000-0600

It's ready, please commit this to CVS.
By: Russell Bryant (russell) 2004-11-15 08:47:56.000-0600

Please update any related config files in your patch.  Correct me if I missed something.

Thanks!
By: Andrey S Pankov (casper) 2004-11-15 12:04:39.000-0600

Please see attached...
By: Clod Patry (junky) 2004-11-15 12:29:18.000-0600

maybe it would be a good option for cdr_pgsql too.

If that could help, i can do the same task for cdr_pgsql.c.

What do you think about a config file maybe "cdr.conf" for all information related to CDR?

maybe we could just have classes in this file like:
[pgsql]
;infos related to cdr_pgsql.c in here

[mysql]
;infos related to cdr_mysql.c in here

[tds]
;infos related to cdr_tds.c in here

[odbc]
;infos related to cdr_odbc.c here
and so on.

edited on: 11-15-04 12:31
By: Andrey S Pankov (casper) 2004-11-19 09:03:29.000-0600

Any chance somebody will merge these patches into CVS HEAD and v1-0? :)
By: Andrey S Pankov (casper) 2004-11-19 09:33:34.000-0600

By "these patches" I mean  "cdr_odbc.c.diff.txt (3,602 bytes) 10-31-04 14:42" and
"cdr_odbc.conf.sample.diff.txt (515 bytes) 11-15-04 12:05" :)
By: Clod Patry (junky) 2004-11-23 20:42:45.000-0600

what do you think about the idea behind the cdr.conf (like i said ealier)?
By: Andrey S Pankov (casper) 2004-11-25 06:52:52.000-0600

Patches updated to the current CVS.

casper
By: Andrey S Pankov (casper) 2004-12-10 03:09:13.000-0600

Really surprise by the fact ASTERISK-2899 is in CVS now (being 99% cut'n'past), and this patch is not :(
By: Russell Bryant (russell) 2004-12-10 07:04:54.000-0600

Like you said, since 2951 is virtually identical to this, I figured Mark would be ok with this.  It is in CVS head, but not in stable.

Thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:16:09.000-0600

Repository: asterisk
Revision: 4416

U   trunk/cdr/cdr_odbc.c
U   trunk/configs/cdr_odbc.conf.sample

------------------------------------------------------------------------
r4416 | russell | 2008-01-15 15:16:08 -0600 (Tue, 15 Jan 2008) | 2 lines

make table configurable for cdr_odbc (bug ASTERISK-2708)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4416