[Home]

Summary:ASTERISK-02638: Fresh asterisk cvs won't compile - suspect lock.h
Reporter:tan (tan)Labels:
Date Opened:2004-10-20 01:08:35Date Closed:2004-10-23 08:40:05
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:On doing a compilation of latest head cvs, we get the following error:

In file included from localtime.c:29:
../include/asterisk/lock.h: In function `__ast_pthread_mutex_unlock':
../include/asterisk/lock.h:270: warning: too many arguments for format
../include/asterisk/lock.h:273: structure has no member named `rentrancy'
localtime.c: At top level:
localtime.c:189: warning: initialization makes integer from pointer without a ca
st
localtime.c:190: warning: initialization makes integer from pointer without a ca
st
localtime.c:191: warning: initialization makes integer from pointer without a ca
st
localtime.c:192: warning: initialization makes integer from pointer without a ca
st
make[2]: *** [localtime.o] Error 1
make[2]: Leaving directory `/usr/src/asterisk/stdtime'

Looking at line 273 of the lock.h code it seems that there is a typo relating to "rentrancy". Shown below:

if (!t->rentrancy) {
       t->file = NULL;
       t->lineno = 0;
       t->func = NULL;
       t->thread = 0;
}

Modifying the line to if (!t->reentrancy)... seems to fix it.


Thanks
Tan
Telappliant

****** ADDITIONAL INFORMATION ******

File: lock.h            Status: Up-to-date

  Working revision:    1.25
  Repository revision: 1.25    /usr/cvsroot/asterisk/include/asterisk/lock.h,v
  Sticky Tag:          (none)
Comments:By: Edwin Groothuis (mavetju) 2004-10-20 01:11:51

Also note the argument count in the fprintf() at line 270:

   fprintf(stderr, "%s line %d (%s): Freed more times than we've locked!\n",
       filename, lineno, func, mutex_name);

3 %'s, four arguments.
By: Mark Spencer (markster) 2004-10-20 08:26:40

This only happens when you're using debug threads -- obvoiusly not major.
By: Mark Spencer (markster) 2004-10-20 08:35:09

Fixed in CVS