Summary:	ASTERISK-02620: [PATCH] Make operator=no feature of app_voicemail behave as documented
Reporter:	kb1_kanobe2 (kb1_kanobe2)	Labels:
Date Opened:	2004-10-17 13:47:04	Date Closed:	2008-01-15 15:11:11.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) patch-vm-transfer-operator.diff
Description:	'operator=yes/no' is not consistently handled in app_voicemail in v1-0. If operator=yes the feature behaves as expected. However, if operator=no and 0 is pressed during the greeting stage the transfer always occurs. If 0 is pressed during the recording stage 'vm-sorry' is played and the behaviour is as expected. However, if the account has email notification enabled a new voicemail notice is generated and delivered even though the recorded voicemail has been deleted, causing: WARNING[...]: app_voicemail.c:784 base_encode: Failed to open log file: /var/spool/asterisk/voicemail/.... in console, and very confused users looking for voicemail  recordings that don't exist. Reviewing the code it seems the recording was intended to be both vm-deleted and vm-msgsaved at different points after '0' is hit during recording - this patch assumes vm-deleted to be the correct course of action in all cases. Playback of 'transfer.gsm' has also been inserted prior to the transfer occuring to make the behaviour crystal clear to the calling party, however this may not be desireable for inclusion in cvs. ****** ADDITIONAL INFORMATION ****** Voicemail seems to be undergoing lots of changes in head, so in the spirit of Stable this is implemented with as few structural changes as possible. However, the code involved in this feature really could do with being refactored. This patch also includes a bonus fix to a trivial VERBOSE message typo in pbx.c Disclaimer on file.
Comments:	By: Mark Spencer (markster) 2004-10-17 18:22:20 Fixed in CVS head.  THanks! By: Russell Bryant (russell) 2004-10-23 07:51:45 fixed in 1.0 By: Digium Subversion (svnbot) 2008-01-15 15:10:49.000-0600 Repository: asterisk Revision: 4030 U   trunk/apps/app_voicemail.c U   trunk/include/asterisk/lock.h U   trunk/include/asterisk/utils.h U   trunk/pbx.c U   trunk/utils.c ------------------------------------------------------------------------ r4030 | markster | 2008-01-15 15:10:49 -0600 (Tue, 15 Jan 2008) | 2 lines Thread fixes, vm fix (bug ASTERISK-2620) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4030 By: Digium Subversion (svnbot) 2008-01-15 15:11:11.000-0600 Repository: asterisk Revision: 4058 U   branches/v1-0/apps/app_voicemail.c U   branches/v1-0/pbx.c ------------------------------------------------------------------------ r4058 | russell | 2008-01-15 15:11:11 -0600 (Tue, 15 Jan 2008) | 2 lines make operator=no work correctly, fix typo (bug ASTERISK-2620) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4058