| Summary: | ASTERISK-02613: Breakage of ChanIsAvail because of bad hangup handling... | ||
| Reporter: | Michael Loftis (mloftis) | Labels: | |
| Date Opened: | 2004-10-15 02:08:34 | Date Closed: | 2008-01-15 15:10:36.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_queue |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) asterisk-chan_agent.c_isavail_fix-1.patch ( 1) chan_agent.c_isavail_fix.patch | |
| Description: | agent_hangup() will dump a logged in agent (AgentCallbackLogin specifically) after taking one call, then they can almost never take another call because 'start' is never 0 so howlong is always from the last time start was taken. Attached patch sets start to 0 when agent_hangup figures out howlong. This makes sure that when agent_hangup is called without doing a complete agent_call sequence we don't end up logging off an agent who's merely waiting around for a call when we do a ChanIsAvail() from the dial plan. ****** ADDITIONAL INFORMATION ****** Attached patch should fix it, actual patch is against Stable, but anyone could easily bolt it into HEAD. | ||
| Comments: | By: Olle Johansson (oej) 2004-10-15 13:15:12 Please confirm that you have sent in a disclaimer. Read the bug report guidelines! By: Michael Loftis (mloftis) 2004-10-15 15:20:25 Just faxed in that about 10-15 minutes ago now...I revised the patch some. Turns out you basically always need to set p->start as 0. We don't use regular agents here (IE non call back agents) so it does need testing By: Mark Spencer (markster) 2004-10-16 11:02:07 Fixed in CVS By: Russell Bryant (russell) 2004-10-16 11:50:01 fixed in 1.0 By: Digium Subversion (svnbot) 2008-01-15 15:10:35.000-0600 Repository: asterisk Revision: 4015 U trunk/channels/chan_agent.c ------------------------------------------------------------------------ r4015 | markster | 2008-01-15 15:10:35 -0600 (Tue, 15 Jan 2008) | 2 lines Fix hangup handling with chansiavail with agent (bug ASTERISK-2613) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4015 By: Digium Subversion (svnbot) 2008-01-15 15:10:36.000-0600 Repository: asterisk Revision: 4016 U branches/v1-0/channels/chan_agent.c ------------------------------------------------------------------------ r4016 | russell | 2008-01-15 15:10:36 -0600 (Tue, 15 Jan 2008) | 2 lines Fix hangup handling with chansiavail with agent (bug ASTERISK-2613) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4016 | ||