[Home]

Summary:ASTERISK-02600: [PATCH] Tweak 'pri debug' so output is displayed even when verbosity = 0
Reporter:kb1_kanobe2 (kb1_kanobe2)Labels:
Date Opened:2004-10-13 23:56:23Date Closed:2008-01-15 15:10:29.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk-pridebug-vs-verbosity.diff
Description:zt_pri_message() in chan_zap.c tests that option_verbose > 0 before providing output, which makes the behaviour of 'pri debug...' counter intuitive compared to the behaviour of 'iax debug' and so on.

This patch simply removes the test of option_verbose as all of the calls to pri_message() within libpri already test to see pri->debug is set first.

Yes, it's trivial.

****** ADDITIONAL INFORMATION ******

With thanks to Citats for helping my understanding of C.

Disclaimer is on file.
Comments:By: Mark Spencer (markster) 2004-10-14 00:03:01

Agreed and fixed in CVS.
By: Russell Bryant (russell) 2004-10-14 18:46:44

fixed in the 1.0 branch
By: Digium Subversion (svnbot) 2008-01-15 15:10:18.000-0600

Repository: asterisk
Revision: 3993

U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r3993 | markster | 2008-01-15 15:10:18 -0600 (Tue, 15 Jan 2008) | 2 lines

Make PRI debug work when verbosity = 0 (bug ASTERISK-2600)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=3993
By: Digium Subversion (svnbot) 2008-01-15 15:10:29.000-0600

Repository: asterisk
Revision: 4007

U   branches/v1-0/channels/chan_zap.c

------------------------------------------------------------------------
r4007 | russell | 2008-01-15 15:10:29 -0600 (Tue, 15 Jan 2008) | 2 lines

show output with 'pri debug' with verbosity set to zero (bug ASTERISK-2600)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4007