[Home]

Summary:ASTERISK-02592: [patch] preliminary zap reload from cli (no signalling, just parameters)
Reporter:twisted (twisted)Labels:
Date Opened:2004-10-13 01:24:03Date Closed:2008-01-15 15:10:43.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) reload_chan_zap.txt
( 1) zap-reload2.txt
( 2) zap-reload3.txt
Description:This patch applies to current cvs head as of 10/13/04 at 1.22am.  This patch allows you to modify the settings in /etc/asterisk/zapata.conf and issue a 'zap reload' at the CLI to reload channel information.  

On verbose level 5, we output the parameters we ignore.  I've also ifdef and ifndef'd some of the changes to allow us to (eventually) do signalling changes, etc..  

Also - you can reload while zap channels are in use.

I hope you like this one ;)

****** ADDITIONAL INFORMATION ******

Disclaimer is on file.
Comments:By: twisted (twisted) 2004-10-13 01:28:02

OH - forgot to mention.  I can only partially test it on my system, and what I tested, works fine. :)
By: Russell Bryant (russell) 2004-10-13 09:43:25

I was able to make this break in the following scenario ...

signalling=fxo_ks
channel => 1-20
signalling=fxs_ks
channel => 21-24

Even though I did not change these parameters, it tries to set the signalling for channels 1-20 to fxs_ks.  After commenting the parameters for the last four channels, it appeared to work fine.

edited on: 10-13-04 09:45
By: James Golovich (jamesgolovich) 2004-10-13 10:09:23

I think this is going about it slightly the wrong way.  (Too much code duplication required).  reload_zt should get removed completely, and setup_zap should be called for the initial setup and the reconfiguration.  Its just a tiny bit of moving code around to get it to work right.
By: twisted (twisted) 2004-10-13 10:36:44

well, excuse me for trying, but take note:

1) reload_zt() already existed.  I just expanded on it.
2) i'm still learning C
3) the subject even says, "preliminary"
4) I just need you to test, not bash just yet.

thanks.
By: twisted (twisted) 2004-10-13 10:38:24

zap-reload2.txt fixes the issue drumkilla had with the signalling

jamesgolovich, sorry for the previous post, but it seems we are a bit too quick to make critisims on things in 'experimental features' that are marked with 'preliminary'

edited on: 10-13-04 10:39
By: James Golovich (jamesgolovich) 2004-10-13 11:33:41

Whoa, settle down.  I'm providing constructive criticism.  It's a good thing.
By: twisted (twisted) 2004-10-13 11:47:57

critisim, smitisim, check zap-reload3.txt - same great taste, without the extra carbs.  (thanks citats for the pointer..hehe)
By: twisted (twisted) 2004-10-16 16:52:16

reload_chan_zap.txt is the one that conforms to the actual method of reloading modules post-1.0:  reload chan_zap.so
By: Mark Spencer (markster) 2004-10-16 18:35:50

Fixed in CVS, yay!
By: Russell Bryant (russell) 2004-10-17 00:47:39

not included in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:10:43.000-0600

Repository: asterisk
Revision: 4023

U   trunk/CREDITS
U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r4023 | markster | 2008-01-15 15:10:42 -0600 (Tue, 15 Jan 2008) | 2 lines

Make chan_zap reloadable (bug ASTERISK-2592)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4023