[Home]

Summary:ASTERISK-02583: [patch] terminator key for app_record
Reporter:Clod Patry (junky)Labels:
Date Opened:2004-10-11 20:13:47Date Closed:2008-01-15 15:12:02.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) terminator.txt
Description: This patch allows the possibility to choose the * key for the terminator key in the app_record application. Often, in arabian countries, users prefer to use the * key instead of the # key to terminates the record.

****** ADDITIONAL INFORMATION ******

Example of use:
exten => 92,1,Record(/tmp/test_record:gsm|||star); the terminator key will be *
exten => 92,2,Sox(/tmp/test_record.gsm);
exten => 92,3,Record(/tmp/test_record:gsm); the terminator key will be #
exten => 92,4,Sox(/tmp/test_record.gsm);

So if ya want the same behavior as before, just don't specify the star as args.



Comments:By: Mark Spencer (markster) 2004-10-11 22:17:44

How about we make the options single letter ones like those in dial?  Look for the two existing ones and if not, then look for patterns like "s" for skip, "n" for noanswer and "t" for "star terminator" or something...
By: Clod Patry (junky) 2004-10-11 22:41:54

if you prefer the "t option" for star terminator, i've no trouble to change my patch, is it exactly what you want ?
Plus, i dont think the n and s flag is available at this moment for app_record.
Only noanswer and skip is supported.
I know anthm added these flags into the app_sox, but isn't available yet for app_record.
i've added terminator, cause i think that would be easy if any future of terminator wants like any digits, or just certain digits in particular.

So just tell me what you prefer, exactly.

Cheers
By: Mark Spencer (markster) 2004-10-12 09:46:40

Well most of the new commands have options that are single letters.  This app only uses "word" options right now.  My suggestion is to migrate from "word" options to "letter" options.  To do so, we retain backwards compatibility with the "word" options, but now if it doesn't match the existing word options, we try it as letter options.
By: Clod Patry (junky) 2004-10-12 20:40:22

the problem is that if we wanna use the option with the single letter, we need to do something, cause, if we use the s (for skip) could have problem with the old version (with the word noanSwer). The letter n (for noanswer) could have problem with the word termiNator).

Plus, we should planify an option for appending sound to an existing sound.
Maybe, the letter a, for append.

Any idea for the switch between "word" to "letter" ?
By: Mark Spencer (markster) 2004-10-12 20:57:23

The idea is something like:

if (!strcasecmp(options, "answer")) {
} else if (!strcasecmp(options, "skip")) {
} else {
      /* Check for individual options */
}
By: Clod Patry (junky) 2004-10-14 18:08:49

what about adding an option "a" for appending record to an existing file ?
by default, it overwrites the file, and some needs requires to append record to files.
By: Mark Spencer (markster) 2004-10-14 22:35:28

Sure, I'm game for an "a" option.
By: Clod Patry (junky) 2004-10-15 00:53:40

what i suggest is to create a new option append, try it at the same time of the terminator and then do a progressive switch to "letters" option too. What do you think about it ?
By: Clod Patry (junky) 2004-10-25 21:50:31

any news related to that bug ?

and one more thing could be done too, is add a flag for the append in the RECORD FILE command in AGI.
By: sdavid14 (sdavid14) 2004-10-28 07:59:01

for outbound calling i'm trying to use app_record with silence detection to wait for a greeting to finish before speaking a message.  so i have two suggestions to add to app_record relating to this bug:

1. leave the silence detection setting in milliseconds, do not convert to whole seconds.   (1.2 seconds is a comfortable silence upon answering)
2. give the option to skip the 'beep' in app_record.

(ps.... using app_dial for good, not evil!)
By: Mark Spencer (markster) 2004-10-28 15:04:59

Just redid everything, reopen if it needs more work.
By: Russell Bryant (russell) 2004-10-29 10:20:05

not included in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:12:02.000-0600

Repository: asterisk
Revision: 4120

U   trunk/apps/app_record.c

------------------------------------------------------------------------
r4120 | markster | 2008-01-15 15:12:02 -0600 (Tue, 15 Jan 2008) | 2 lines

Record application updates (bug ASTERISK-2583)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4120