| Summary: | ASTERISK-02565: cidmatch broken when pattern contains ranges | ||
| Reporter: | raburton (raburton) | Labels: | |
| Date Opened: | 2004-10-08 10:10:28 | Date Closed: | 2008-01-15 15:09:42.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Latest version of pbx_config (1.49) contains a call to ast_shrink_phone_number (line 1664) for the cidmatch string. This function removes the '-' used in ranges e.g. exten => s/_080058752[1-8]0,1,Answer The cidmatch string then becomes "_080058752[18]0", and so when matched against incoming callerid will only match the two ends of the range (1 & 8 in this example), but not anything in between. This call either needs to be removed, or changed to call a new version of ast_shrink_phone_number that is more intelligent about stripping chars (e.g. understands '-' is valid in side [ ]s). I'd just remove the call, unless it was an integral part of the last change (no bug number in cvs for this change, so I can't check that). ****** ADDITIONAL INFORMATION ****** Disclaimer on file. | ||
| Comments: | By: Mark Spencer (markster) 2004-10-08 11:48:25 Fixed in CVS. By: Digium Subversion (svnbot) 2008-01-15 15:09:42.000-0600 Repository: asterisk Revision: 3951 U trunk/callerid.c ------------------------------------------------------------------------ r3951 | markster | 2008-01-15 15:09:42 -0600 (Tue, 15 Jan 2008) | 2 lines Don't strip bracketed hyphens (bug ASTERISK-2565) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3951 | ||