[Home]

Summary:ASTERISK-02553: Problem with MWI in the bugfix of chan_sip.v ver 1.520 - 1.521
Reporter:Fernando Romo (el_pop)Labels:
Date Opened:2004-10-07 08:33:18Date Closed:2004-10-07 17:46:39
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sipfix2.txt
Description:i test the last CVS snapshot daily and i use Polycom (Soundpoint IP 300) and GrandStream Budgetone Phones. with the revision 1.520 of chan_sip.c the MWI feature works fine. when i update to the las version available (1.521), the MWI stop to work.

****** ADDITIONAL INFORMATION ******

when i check the CVS log of chan_sip.c found this:

----------------------------
revision 1.521
date: 2004/10/06 04:40:57;  author: markster;  state: Exp;  lines: +1 -1
Use reqprep, not initreqprep for NOTIFY for REFER...
----------------------------
revision 1.520
date: 2004/10/06 04:30:15;  author: markster;  state: Exp;  lines: +2 -2
Locking updates for debug mode, fix SIP MWI (bug ASTERISK-2540)
----------------------------

The fix of version 1.520 work fine, but the change on "initreqprep" for  "reqprep" deactivate the MWI feature.

The diff showme this:

cvs diff -r 1.520 chan_sip.c

----------------------------------------
Index: chan_sip.c
===================================================================
RCS file: /usr/cvsroot/asterisk/channels/chan_sip.c,v
retrieving revision 1.520
retrieving revision 1.521
diff -u -d -b -w -r1.520 -r1.521
--- chan_sip.c  6 Oct 2004 04:30:15 -0000       1.520
+++ chan_sip.c  6 Oct 2004 04:40:57 -0000       1.521
@@ -3939,7 +3939,7 @@
      char tmp[256];
      char tmp2[256];
      char clen[20];
-       initreqprep(&req, p, "NOTIFY", NULL);
+       reqprep(&req, p, "NOTIFY", 0, 1);
      add_header(&req, "Event", "message-summary");
      add_header(&req, "Content-Type", notifymime);


For now i am working with version 1.520 of chan_sip.c. This message is for notify purposes.

Best Regards....... Fernando Romo
                           pop@cofradia.org
Comments:By: kuj (kuj) 2004-10-07 10:12:01

Same as ASTERISK-2548
By: Mark Spencer (markster) 2004-10-07 11:46:30

Fixed in CVS, I had changed the wrong initreq.
By: Russell Bryant (russell) 2004-10-07 17:46:39

fixed in 1.0 branch