| Summary: | ASTERISK-02552: [patch] memset fixes | ||
| Reporter: | Andrey S Pankov (casper) | Labels: | |
| Date Opened: | 2004-10-07 06:47:00 | Date Closed: | 2008-01-15 15:10:08.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) chan_mgcp.c.diff ( 1) chan_mgcp[1].c.txt | |
| Description: | To reproduce unappropriate behavior just turn on "mgcp debug" and see "MGCP read:" output. Other back side effects may or may not exist (not analyzed). | ||
| Comments: | By: Andrey S Pankov (casper) 2004-10-07 06:51:07 The disclaimer has been sent by fax to Digium today. By: Mark Spencer (markster) 2004-10-07 11:55:03 Obviously this is not a major bug, please read the instructions for bug submissions when placing further bugs. By: Mark Spencer (markster) 2004-10-07 11:57:32 This patch doesn't appear to make any real change other than the addition of a single \n, since sizeof(req) and sizeof(struct mgcp_request) are the same value when req is a struct mgcp_request. Can you confirm that all you're really trying to do is add a carriage return? By: Andrey S Pankov (casper) 2004-10-08 02:14:14 Really, it turned out that \n has fixed debug output problem, not memsets. I was too tired yesterday to see the real point. :) By: Mark Spencer (markster) 2004-10-10 23:36:08 Fixed in CVS, thanks! By: Russell Bryant (russell) 2004-10-11 22:28:43 fixed in the 1.0 branch By: Digium Subversion (svnbot) 2008-01-15 15:10:03.000-0600 Repository: asterisk Revision: 3976 U trunk/channels/chan_mgcp.c ------------------------------------------------------------------------ r3976 | markster | 2008-01-15 15:10:02 -0600 (Tue, 15 Jan 2008) | 2 lines Add missing carriage return (bug ASTERISK-2552) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3976 By: Digium Subversion (svnbot) 2008-01-15 15:10:08.000-0600 Repository: asterisk Revision: 3982 U branches/v1-0/channels/chan_mgcp.c ------------------------------------------------------------------------ r3982 | russell | 2008-01-15 15:10:07 -0600 (Tue, 15 Jan 2008) | 2 lines add missing (bug ASTERISK-2552) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3982 | ||