| Summary: | ASTERISK-02488: Code cleanup, extensions including regex matching | ||
| Reporter: | Kevin P. Fleming (kpfleming) | Labels: | |
| Date Opened: | 2004-09-28 01:54:35 | Date Closed: | 2008-01-15 15:08:59.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) groupcount_extensions.patch ( 1) groupcount_extensions-2.patch | |
| Description: | Patch does the following: - consolidates group@category splitting into a single function - moves groupcount core functions into app.c (so some of them can be used by other apps {patches forthcoming}) - adds GetGroupMatchCount, which accepts a regex for group name and returns total count of all matching groups found - adds "group show channels" to the CLI, which lists all active channels that have groups assigned; also accepts a regex, which is matched against the group names | ||
| Comments: | By: Mark Spencer (markster) 2004-09-28 08:42:06 Getting the groupcount against a regex would have to be a new app or option to an existing app to retain backwards compatibility and to prevent the overhead of a regex when generally speaking none would be required. By: Kevin P. Fleming (kpfleming) 2004-09-28 09:42:32 There is no overhead, it's completely backwards compatible. If you don't call GetGroupMatchCount, you don't incur any overhead. GetGroupCount is unmodified. By: Mark Spencer (markster) 2004-10-02 10:07:12 Yup looks good, you're right. Can you confirm you have a disclaimer on file? Thanks! By: Kevin P. Fleming (kpfleming) 2004-10-02 23:41:10 It was FAXed last weekend (while you were all at Astricon <G>), under my name and the name of the company of which I am partner (Star Networks, LLC). If you don't have it, email me directly and I'll get it FAXed again tomorrow. By: Mark Spencer (markster) 2004-10-03 00:22:21 Hrm, doesn't seem to apply to current cvs, can you update it when you get a chance? By: Kevin P. Fleming (kpfleming) 2004-10-03 12:16:57 rediffed against current CVS By: Mark Spencer (markster) 2004-10-03 12:33:12 Added to CVS, thanks! By: Russell Bryant (russell) 2004-10-03 12:34:24 not included in the 1.0 branch By: Digium Subversion (svnbot) 2008-01-15 15:08:59.000-0600 Repository: asterisk Revision: 3898 U trunk/app.c U trunk/apps/app_groupcount.c U trunk/include/asterisk/app.h ------------------------------------------------------------------------ r3898 | markster | 2008-01-15 15:08:59 -0600 (Tue, 15 Jan 2008) | 2 lines Improve groupcount handling (bug ASTERISK-2488) thanks! ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3898 | ||