[Home]

Summary:ASTERISK-02474: [patch] cleaned up cdr_mysql.c
Reporter:sivana (sivana)Labels:
Date Opened:2004-09-26 19:33:25Date Closed:2011-06-07 14:10:45
Priority:MinorRegression?No
Status:Closed/CompleteComponents:CDR/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) cdr_mysql.conf.diff
( 1) cdr_mysql.diff
Description:Cleaned up the code quite a bit.  It now checks the database connection and reconnects if needed.  Should be quite a bit more efficient.
Comments:By: drmac (drmac) 2004-09-28 11:59:14

Could you add back in the support from the original cdr_mysql_addon that had the CLI interface to check the status of the connection? I feel that having this would be helpful if anyone ever needed to debug or find out why CDR's aren't being written.  Just my $0.02.
By: Tilghman Lesher (tilghman) 2004-09-28 14:13:59

Please resubmit as a diff against the current code.
By: Tilghman Lesher (tilghman) 2004-09-28 14:17:35

Also:

1) Do you have a disclaimer on file?
2) Note that if you based your code off of existing code, then you have improperly stripped copyright notices.  Please restore them.
By: sivana (sivana) 2004-09-28 14:23:42

I will send in my disclaimer.

I'm not well verse in GPL language, so I wasn't sure how much change falls under "derivative work" and what falls under "pretty much new".  I'll restore the original header and add a note underneath.
By: sivana (sivana) 2004-09-28 14:52:22

disclaimer faxed 9-28-2004
By: twisted (twisted) 2004-10-16 15:25:51

disregard previous bugnote... i deleted it.  My browser hadn't loaded all the bugnotes before I clicked on add..  Sorry for the confusion :)
By: Mark Spencer (markster) 2004-10-16 15:50:28

Looks interesting certainly.  

There appear to be some changes which are formatted improperly.

Asterisk uses the function construct

int foo(void)
{
  return 0;
}

However, for some reason this patch both moves the opening brace *and* deletes the void in the parenthesis which will cause warnings on some compilers.  

Also there appear to be some checks for option_verbose > 10 and then printing things with VERBOSE_PREFIX_4.  These should either be debugs set with "option_debug" or they should be matched option_verbose and VERBOSE_PREFIX if they are of general value.

Can we repair.
By: Brian West (bkw918) 2004-10-17 20:53:22

Mark if thats the case on the verbose stuff I need to fix cdr_odbc.c also

bkw
By: sivana (sivana) 2004-10-17 22:42:40

I put the opening brace on the same line out of personal style, I've moved it to the next line.

Before I upload the changes, which function is missing the void?
By: Mark Spencer (markster) 2004-10-26 00:04:10

Hrm, it doesn't seem to apply cleanly....

The missing void appears to have already been there (function "key").
By: Mark Spencer (markster) 2004-11-09 00:11:03.000-0600

Looks like the author seems to have lost interest in the patch :(
By: sivana (sivana) 2004-11-27 01:29:28.000-0600

Updates
By: sivana (sivana) 2004-11-27 01:32:18.000-0600

I'm not really understanding.  None of the CDR loggers have "void" in the *key() function, in any event, I added it.  I also replaced all the verbose stuff with ast_log().
By: sivana (sivana) 2004-11-27 02:13:33.000-0600

I just added support for defining the table name in the conf.
By: Mark Spencer (markster) 2004-12-12 00:06:06.000-0600

This appears to drop a lot of functionality.  Have you looked at the diff?
By: sivana (sivana) 2004-12-14 01:15:14.000-0600

Yes, I'll re-add the status option from the CLI and make it return more useful information.
By: Clod Patry (junky) 2004-12-21 00:02:50.000-0600

Any updates sivana in here?
Thanks

/Housekeeping
By: twisted (twisted) 2005-01-04 01:21:28.000-0600

sivana, have you revised this to meet the requirements?
By: drmac (drmac) 2005-01-04 08:59:53.000-0600

you removed all the code pertaining to connecting via sockets. can you add this back in?

im kinda bored..would it be benneficial to have this module use RealTime? or how about a generic cdr_realtime.c then everybody can use whatever database they want?

gimme a green light (if you think its worth it) and i'll wip up cdr_realtime.c this week.
By: Clod Patry (junky) 2005-01-07 00:25:48.000-0600

sivana: we need updates from you cause it makes ~2 weeks since i've asked you questions. Lost of interests? Just missing time? We need to know or we'll close this one.

drmac: i can't say if you can or can't do that. Just do it if you feel this good.

Thanks for understanding.

edited on: 01-07-05 00:26
By: Clod Patry (junky) 2005-01-10 21:03:40.000-0600

Reporter shows ~1 months of inactivity.
If someone wants it re-open, feel free to ask a marshall in #asterisk-bugs.

Thanks.