Summary:	ASTERISK-02467: [patch] "Thank you" message should not be played after first position announcement
Reporter:	Kevin P. Fleming (kpfleming)	Labels:
Date Opened:	2004-09-25 22:20:03	Date Closed:	2011-06-07 14:10:07
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_queue
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_queue-skip_first_thanks.patch ( 1) app_queue-skip_first_thanks.patch ( 2) queue_skipfirstthanks-2.patch
Description:	When position announcement is turned on, and the caller enters the queue, the immediately hear "Your call is <n>th in line, and will be answered in the order it was received." This is good :-) However, they then hear "Thank you for your patience", which is OK. However, if the admin has changed that message to offer a menu to the user (say, "press 1 to leave a voicemail"), it is inappropriate to play that message when the caller has not even spent any time on hold yet. The attached patch changes this behavior so that the "thank you" message is only played for the 2nd and subsequent position announcements. If you would prefer that this be a configurable option, I'll make that change and resubmit.
Comments:	By: Russell Bryant (russell) 2004-09-25 23:10:06 It would probably be nice to have this configurable since not everyone wants it to behave the same way.  Also, the default behaviour should be how it works currently. By: rwjblue (rwjblue) 2004-09-25 23:59:14 Works in my test environment.  Have not done load testing yet.  It would be nice to have it configurable, but it is perfectly fine for us currently. Disclaimer on file? By: Kevin P. Fleming (kpfleming) 2004-09-26 00:09:04 Disclaimer was faxed today, should be processed on Monday. I will repost tomorrow with a configuration option "skipthankyouonfirstannounce", unless someone decides on a better option name. By: Russell Bryant (russell) 2004-09-26 13:07:42 Maybe it could be a little shorter, like 'skipfirstthankyou' or something.  Also, go ahead and document the option in the queues.conf.sample and include that in your next patch. By: Kevin P. Fleming (kpfleming) 2004-09-28 01:21:58 Replacement patch uploaded. Option is now configurable (as "skipfirsthankyou"), with sample in queues.conf.sample. By: Kevin P. Fleming (kpfleming) 2004-10-03 12:18:25 rediffed against current CVS By: twisted (twisted) 2004-10-03 17:29:47 Here's an option I like: in the queues.conf file, per queue, firstthankyou=xxx where xxx can be a sound file name, or a ast_true() false value which would completely disable the first thankyou alltogether.  ie, firstthankyou=queue-thanks.gsm would say thank you for your patience firstthankyou=off would disable the first message alltogether firstthankyou=press1vm.gsm would play your press one to leave a voicemail file. Simple enough? maybe even allow this to happen all the way through the call would be decent too.... that way the periodic hold messages are also configurable. *shrug* By: Kevin P. Fleming (kpfleming) 2004-10-12 23:37:03 This bug and bug 002615 are trying to solve some of the same problems, and as twisted has already hinted at here, we need to come up with a more complete solution for controlling which messages are played at what times. That bug may be a better place to continue this discussion (although it's not categorized as being for "app_queue"), and if so this bug can be killed and I'll try to jump in over there to come up with something that will work for all of us. By: twisted (twisted) 2004-10-27 17:03:18 Closed per kfleming, sorry about the delay.. I've been slacking apparently ;)