Summary:ASTERISK-02461: [patch] Holdtime incorrectly announced as '1 minutes' when holdtime less than 2 minutes
Reporter:davetroy (davetroy)Labels:
Date Opened:2004-09-24 15:51:10Date Closed:2008-01-15 15:08:09.000-0600
Versions:Frequency of
Environment:Attachments:( 0) app_queue.c.diff.20040924
Description:Original implementation of holdtime announcement was based on the notion of not announcing holdtimes smaller than two minutes.  To do otherwise would require another recording, etc.

Someone added ability to announce second estimation as well as minutes.  I am not sure this is a great idea, since the seconds estimation is probably not statistically sound.

Anyway, this fixes the holdtime announcement so it won't say "holdtime is one minutes".  It just won't say holdtime unless it rounds to 2 minutes or more.

Another option for this would be to have Allison record a soundfile "The estimated holdtime is currently one minute or less."


Yes, I have a disclaimer on file. :)
Comments:By: rwjblue (rwjblue) 2004-09-24 17:19:08

Seems to work correctly for me.  Tested by forcing the avg hold time up and listening.  Didn't try with tons of calls, but seems to be OK.  I believe that there is a reference in queues.conf saying that the avg holdtime will be said if it is greater than 60 seconds.  Shouldn't we also update that file so that the example comments are correct?  Just a suggestion.

By: Mark Spencer (markster) 2004-09-25 10:19:55

Fixed in CVS to say "less than two minutes" instead of "one minutes"

By: Russell Bryant (russell) 2004-09-25 23:06:32

example config updated

By: Digium Subversion (svnbot) 2008-01-15 15:08:09.000-0600

Repository: asterisk
Revision: 3834

U   trunk/apps/app_queue.c
U   trunk/res/res_agi.c
A   trunk/sounds/queue-less-than.gsm
U   trunk/sounds.txt

r3834 | markster | 2008-01-15 15:08:09 -0600 (Tue, 15 Jan 2008) | 2 lines

Make holdtime announcement say "less than 2 minutes" instead of "1 minutes" (bug ASTERISK-2461)