[Home]

Summary:ASTERISK-02419: [patch] Pick-up extension is not configurable
Reporter:Andrey S Pankov (casper)Labels:
Date Opened:2004-09-16 03:47:20Date Closed:2011-06-07 14:04:40
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 2454.diff
( 1) pickupexten.patch.txt
Description:To make transition from legacy PBX easier it would be nice to have pick-up ext configurable (e.g. for Panasonic PBX it is **)

****** ADDITIONAL INFORMATION ******

Here is the patch:
--- res_features.c      10 Sep 2004 15:11:38 -0000      1.12
+++ res_features.c      16 Sep 2004 08:45:19 -0000
@@ -868,10 +868,12 @@
                                       transferdigittimeout = DEFAULT_TRANSFER_DIGIT_TIMEOUT;
                               } else
                                       transferdigittimeout = transferdigittimeout * 1000;
                       } else if  (!strcasecmp(var->name, "courtesytone")) {
                               strncpy(courtesytone, var->value, sizeof(courtesytone) - 1);
+                       } else if (!strcasecmp(var->name, "pickupext")) {
+                               strncpy(pickup_ext, var->value, sizeof(pickup_ext) - 1);
                       }
                       var = var->next;
               }
               ast_destroy(cfg);
       }
--- features.conf.sample        31 Aug 2004 19:19:05 -0000      1.3
+++ features.conf.sample        16 Sep 2004 08:47:17 -0000
@@ -9,5 +9,6 @@
;parkingtime => 45             ; Number of seconds a call can be parked for
                               ; (default is 45 seconds)
;transferdigittimeout => 3     ; Number of seconds to wait between digits when transfering a call
;courtesytone = beep           ; Sound file to play to the parked caller
                               ; when someone dials a parked call
+;pickupext => **               ; Pick-up extension (default is *8)
Comments:By: Mark Spencer (markster) 2004-09-16 14:41:20

Do you have a disclaimer on file, and can you attach you diff as a cvs diff -u as per the bug guidelines?  Thanks!
By: Andrey S Pankov (casper) 2004-09-17 03:33:23

Please find the diff file attached...
By: Mark Spencer (markster) 2004-09-17 08:31:42

And can you confirm you have a disclaimer on file?
By: Mark Spencer (markster) 2004-09-17 17:56:49

See http://bugs.digium.com for links to the disclaimers :)

Thanks!
By: Brian West (bkw918) 2004-09-17 19:30:23

Have you sent in your disclaimer yet?
By: Mark Spencer (markster) 2004-09-26 13:56:58

I'm going to suspend this one until we get a disclaimer or confirmation that a disclaimer is already on file.
By: Russell Bryant (russell) 2004-09-26 14:28:39

I didn't look at the additional info and made my own version.  To my absolute surprise, it turned out to be incredibly similar!!!  Anyway, here it is.
By: Mark Spencer (markster) 2004-09-26 16:19:57

Looks good, commit away!
By: Russell Bryant (russell) 2004-09-26 16:48:44

fixed in CVS