[Home]

Summary:ASTERISK-02406: Karma changes (please ignore)
Reporter:paulc (paulc)Labels:
Date Opened:2004-09-14 23:38:56Date Closed:2011-06-07 14:04:46
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) fix_bug_view_advanced_page_2.diff
( 1) fix_bug_view_advanced_page.diff
Description:Bug for all karma-related questions, created following discussion on IRC/conf.

Ideas mentioned on the conf include showing the user's karma score next to their name in the drop down list of users for karma transactions, and also limiting that list only to people who have created a bug. Not sure on that one - might affect karma awards to people who submit patches for a bug but weren't necessarily the creator?

Please comment with thoughts on the above + any new things you'd like to see developed with the karma system.
Comments:By: twisted (twisted) 2004-09-14 23:40:17

It breaks on "advanced view" ;)

SYSTEM WARNING: Missing argument 2 for html_buttons_view_bug_page()


Fatal error: Call to undefined function: karma_html_button() in /var/www/bugs/core/html_api.php on line 815

edited on: 09-14-04 23:41

By: paulc (paulc) 2004-09-15 20:27:19

Please see attached fix_bug_biew_advanced_page_2.diff - when applied it will update bug_view_advanced_page.php to include display of the user's karma score as well as the karma transactions button for appropriately privileged users.

By: Mark Spencer (markster) 2004-09-15 21:09:05

paulc, on a slightly unrelated note, is it fairly easy to display the user who last made a comment on each bug on the main "view bugs" page?

By: paulc (paulc) 2004-09-23 14:10:36

Mark - delayed reply, sorry - I didn't get an update email for some reason :-s

Sure, that's doable I think.. You want to show the author of the most recent comment on a bug on the view all bugs page right? like an extra column? I'll take a look and post a patch in the next day or two if it's doable.

By: Clod Patry (junky) 2004-10-06 22:31:34

that would be great if we can see all karma points for everyone in one page.

and when person add notes, that would be great if we can see their karma just as if we submit the bugs.

Thanks.

By: zoa (zoa) 2004-10-07 01:45:28

yes and some cheatcodes to make sure im not staying with a negative karma :p

By: Russell Bryant (russell) 2004-11-21 00:56:24.000-0600

Reminder sent to malcolmd

I think there is a patch for Mantis in here that they would like you to apply.

Russell

By: Olle Johansson (oej) 2004-12-12 15:59:10.000-0600

Ignoring this - should we keep it open just by continuing to ignore it or should we close it? Who cares? ;-)

/Ignored Housekeeper

By: Clod Patry (junky) 2004-12-13 12:33:06.000-0600

what about my ideas dated as 10-06-04 22:31?
paulc, do you think it's possible easily to do that too?

And that would be cool to add the note number too, like note #1, note #2, etc.
so if a person wants to refer to a note, he could refer to a # instead of a date (like i just did) :)


that would be cool for everyone, i think.

edited on: 12-13-04 12:33

By: paulc (paulc) 2004-12-13 17:12:36.000-0600

Showing karma scores next to each bug comment poster's name is probably doable, should just be a case of adding the karma scores table to the query and showing the result. I'm not the biggest fan of delving in to the Mantis code though cos it's ugly.. Also, the more changes we make, the more out of sync the Digium installation of Mantis gets with the currently released version (there's already a mismatch).

As for note number display for comments.. again, doable.. but could get out of whack if comments are deleted or made private (as I'd probably do a quick'n'dirty hack to just show the row number from the results set). Not sure how the newer version of Mantis stacks up with this kind of thing?

Bottom Line: It's all doable.. just a case of time and motivation, and willingness from TPTB (the powers that be).

By: Clod Patry (junky) 2004-12-14 14:44:46.000-0600

i was talking with klicTel, and he gives me a good idea during our discussion.
That would be cool if we could trade karma points between users, no?
Like when we were in primary school, we were having monopoly points, that would be great to port that idea here too.

Maybe at the end, we could have rebates on digium hardwares (if markster approves it)?

I dont know if that would be easily done, but we could just substracts from 1 member to adds to another and make some verifications.

By: zoa (zoa) 2004-12-14 14:50:01.000-0600

could i give my -1 to someone so that i can finally get rid of it ? :p

By: Brian West (bkw918) 2005-01-02 00:15:13.000-0600

Isn't this already taken care of?