[Home]

Summary:ASTERISK-02350: [Patch] Make w flag work better, and say prompt on enter/leave of marked
Reporter:mochouinard (mochouinard)Labels:
Date Opened:2004-09-05 12:10:19Date Closed:2008-01-15 15:27:39.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_meetme-markedjoin-v1.diff
( 1) app_meetme-markedjoin-v2.diff
( 2) app_meetme-markedjoin-v3.diff.txt
( 3) app_meetme-markedjoin-v4.diff.txt
( 4) conf-leaderhasleft.gsm
( 5) conf-placeintoconf.gsm
( 6) conf-userswilljoin.gsm
( 7) conf-userwilljoin.gsm
( 8) conf-waitforleader.gsm
( 9) sounds.txt
Description:This is a patch that came from my other patch 1562.
It add enter/leave admin prompt.

****** ADDITIONAL INFORMATION ******

PROMPT :
conf-waitforchairman - The conference will begin when the chairman arrived
conf-userwilljoin - User will join the conference
conf-adminhasleft - The chairman has left the conference
conf-placeintoconf - You will now be placed into the conference
Comments:By: Olle Johansson (oej) 2004-09-05 13:54:00

Yes, this is disclaimed :-)
By: Mark Spencer (markster) 2004-09-05 15:31:27

Can we get recordings with the next batch from allison?  thanks!
By: Tony Mountifield (softins) 2004-09-10 17:19:51

Looks like this is a better solution than my one in ASTERISK-2284

I've read the patch through but not tried it. Can you confirm that all 'w' users will be put in MOH if the last 'A' user leaves? And that they will be picked up again if an 'A' user joins again?

One other point. I was playing a couple of weeks ago with recording conferences using the conf->chan channel in ZT_CONF_CONFANNMON mode instead of ZT_CONF_CONFANN. I noticed that with users on MOH while waiting for an administrator, it still recorded what they said, although they each couldn't hear it. My suggestion is to turn off TALK mode on the user's channel when they are put in MOH, and restore it (unless they are CONFFLAG_MONITOR). Or is this what your ZT_CONF_CONF stuff does?
By: Mark Spencer (markster) 2004-09-11 09:57:09

You would not need to do that to record the conference, all you have to do is quietly add a Local channel hooked to a recording extension into the conference.

We're still missing the recordings from Allison, maybe John Todd should be contacted so he can get them in the next batch.

Are there any changes to the documentation that should be accompanied by this patch?

Also, can you add parenthesis around the places you use a & b && c & d to make it easier to understand the code?  Thanks!
By: mochouinard (mochouinard) 2004-09-11 23:40:03

softins, Exactly, unless you specified the x flag on the conference
Mark, please correct or rephrase the prompt as needed, Im french canadian.

For the documentation, that patch just make w flag work like it should, it seem broken on the current setup.  So there is no new command, but I actually added prompt, but that it.

Let me know if you want me to do others changes on this

edited on: 09-11-04 23:44
By: mochouinard (mochouinard) 2004-10-27 13:51:19

Anyone could get the TEXT and make the recording by alison ?
By: Russell Bryant (russell) 2004-11-07 20:14:17.000-0600

Someone needs to get these recordings if this is ever going to make it in ...

-- Housekeeping
By: mochouinard (mochouinard) 2004-11-07 21:20:41.000-0600

no really ? Im waiting for them, and I'll upload a new complete patch for head.  But Im not gonna lost more time on updating stuff until it in the stage to going to head, that mean PROMPTs
By: twisted (twisted) 2004-11-14 23:43:34.000-0600

Moc, please do not take this kind of message personally.   Basically what we have here is what is commonly referred to as a catch-22.  if the patch wont apply, and isn't updated to stay current, it will be closed out.  If the prompts aren't created, it won't go in.  The best thing that you can do is stay calm about it, and when we (the bug marshals, etc) ask for updates, the best way to keep the bug/patch going is to comply, or just simply state that you do not have the resources, and perhaps call on the community for assistance.

If your reply was not meant to be harsh, my apologies, but let's try to figure out how to proceed, as quickly as possible.
By: twisted (twisted) 2004-12-01 00:47:24.000-0600

moc, do you have your prompts recoreded yet?  If not, try and find someone to record them in their next batch.   Also, let's make sure this still applies, as the patch is now over 2 months old.

Thanks!
By: mochouinard (mochouinard) 2004-12-06 20:29:32.000-0600

close it, I guess no one want this feature...
By: Tony Mountifield (softins) 2004-12-07 02:48:12.000-0600

I strongly disagree. I had my bug ASTERISK-2284 closed out in preference to this one, which is a better solution, and have been waiting for this one to make it.

I've been working manically for the last 3 months, so haven't kept a close eye on things, but it looks like this is stalled purely for want of sound files. Other patches seem to have had sound files produced, so why not this one? What is the correct or normal procedure for achieving this?
By: Tony Mountifield (softins) 2004-12-09 16:19:15.000-0600

OK, before I take it upon myself to get these prompts recorded, I'd like to slightly rephrase them. Firstly, I think "leader" is more generic than "chairman". Also, we need both singular and plural: conf-userwilljoin and conf-userswilljoin.

So here is my list (the patch will need to be revised slightly anyway):
conf-waitforleader - "The conference will begin when the leader arrives."
conf-userwilljoin - (1) "user will join the conference."
conf-userswilljoin - (N) "users will join the conference."
conf-leaderhasleft - "The leader has left the conference."
conf-placeintoconf - "You will now be placed into the conference."

Comments? Improvements?

Do I just pay to get them done via thevoice.digium.com and then contribute them, or is there a more community-oriented way to do it?
By: mochouinard (mochouinard) 2004-12-09 19:50:37.000-0600

sound good... Well you have any other feature request for the app ? let me know
By: Leif Madsen (lmadsen) 2004-12-10 11:16:00.000-0600

I'm going to suggest that we also get:

"After the tone, please say your name, then press pound"
"...has joined the conference"
"...has left the conference"

I'd like these for an announced join and leave script.  I'm sure someday someone will just build it right into app_meetme.
By: Russell Bryant (russell) 2004-12-10 17:13:57.000-0600

Ha.  I totally didn't see this.  I started to implement this not too long ago.

See bug http://bugs.digium.com/bug_view_page.php?bug_id=0003006 for prompts.  Maybe we can get them in that batch.
By: Russell Bryant (russell) 2004-12-10 17:20:32.000-0600

Oh wait, I got confused and thought that the thing blitzrage mentioned was in this patch.

Anyway, be sure to include any sounds you want in that bug.
By: twisted (twisted) 2004-12-28 10:42:35.000-0600

*poke*poke* what's going on here?
By: Tony Mountifield (softins) 2004-12-28 11:34:03.000-0600

Just waiting for the prompts to be recorded in the batch associated with bug ASTERISK-2951 and then either I or Moc will get the patch up to date.

edited on: 12-28-04 11:34
By: twisted (twisted) 2005-01-09 22:33:06.000-0600

ASTERISK-3240 appears to have been done - what's the status now?
By: mochouinard (mochouinard) 2005-01-09 23:26:26.000-0600

it 3006 is closed, but no info on the recording have being provided.
By: Tony Mountifield (softins) 2005-01-10 01:43:21.000-0600

Bug ASTERISK-2951 (not 3306) was closed by a bug marshall due to apparent inactivity. In actual fact, Rob Fugina was submitting the order to Allison last week, and I made a donation to ensure the prompts for this Meetme enhancement were included.

As soon as the prompts have been produced, I'll liaise with Moc as required to get the patches updated and re-submitted.
By: Mark Spencer (markster) 2005-01-21 22:52:09.000-0600

Any update on the prompts?
By: brc007 (brc007) 2005-01-21 23:08:45.000-0600

Somebody I know has donated half hour of recording time with Allison to record prompts needed for Asterisk feature additions. I'll try to find some time this weekend to go through the open PATCHes and make a list of the needed prompts (including the ones listed here) to submit to Allison.

edited on: 01-21-05 23:09
By: Tony Mountifield (softins) 2005-01-22 03:29:12.000-0600

The prompts for this patch were included in the batch that RobF did on bug ASTERISK-2951

Those prompts (along with many others in the batch) became available a few days ago, and a sounds.txt is being prepared.

Rob will be uploading the whole batch to ASTERISK-2951 when the sounds.txt is ready, but in the meantime, I've uploaded to here the prompts for this patch.

All that is needed now is for Moc or I to update the patch to the latest.
By: Tony Mountifield (softins) 2005-02-14 06:53:31.000-0600

Moc, I have updated your patches for Stable and Head, and have been trying them out. I think there is a error in some of the logic, and I wanted to check what your intent was.

a) If the first users just have the w flag, they will hear conf-waitforleader.
b) When the first user marked with the A flag joins, then all the waiting users will hear conf-placeintoconf, but the A user will not hear an announcement, unless he also has the w flag.
c) If the first A user also has the w flag, they will hear the number of waiting users followed by conf-userwilljoin.

Is this correct? Or is the first marked user always supposed to hear the number of waiting users?

Also, I think a marked user, if they are the first to arrive, should hear conf-onlyperson, but this doesn't happen currently.
By: mochouinard (mochouinard) 2005-02-27 20:40:16.000-0600

you are correct, current options in meetme aint very great, you need to set w for the user, and wA for the leader to hear the count of user.

Ive uploaded a revised version that work with the prompts added here
By: twisted (twisted) 2005-03-16 18:01:53.000-0600

Closed with no reason given... bkw, please provide a reason when closing bugs.
By: Brian West (bkw918) 2005-03-16 18:09:52.000-0600

No I gave a reason.. leave it be till I talk to Moc I sent him an email.
By: Brian West (bkw918) 2005-03-16 18:10:23.000-0600

Its closed pending getting all these meetme bugs into one nice refined bug note that will not rot away on the bug tracker and never go in anyway.

/b
By: Mark Spencer (markster) 2005-03-16 18:29:04.000-0600

Combining patches together makes it *more* difficult to process, not easier.  Patches are generally easier to work with when they're targeted and relatively short, meaning I can understand more easily what they're doing and it is easier to spot bugs.

In fact, the prompts have been recorded so this patch just needs to be updated and can be immediately applied.
By: mochouinard (mochouinard) 2005-03-16 20:46:57.000-0600

The patch applyed cleanly, this would work fine
By: Mark Spencer (markster) 2005-03-17 14:34:36.000-0600

Added to CVS head, thanks!
By: Russell Bryant (russell) 2005-03-28 00:15:08.000-0600

not included in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:27:39.000-0600

Repository: asterisk
Revision: 5190

U   trunk/apps/app_meetme.c
A   trunk/sounds/conf-leaderhasleft.gsm
A   trunk/sounds/conf-placeintoconf.gsm
A   trunk/sounds/conf-userswilljoin.gsm
A   trunk/sounds/conf-userwilljoin.gsm
A   trunk/sounds/conf-waitforleader.gsm
U   trunk/sounds.txt

------------------------------------------------------------------------
r5190 | markster | 2008-01-15 15:27:39 -0600 (Tue, 15 Jan 2008) | 2 lines

Merge improved announcements for conferences with leader (bug ASTERISK-2350)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5190