Summary:ASTERISK-02343: [Feature + Patch] E-mail info and list for astcc
Reporter:Darren Wiebe (darren)Labels:
Date Opened:2004-09-04 21:16:46Date Closed:2004-09-25 02:01:41
Versions:Frequency of
Environment:Attachments:( 0) diff
( 1) diff
Description:I have added support for a couple of different features which I required.  I'm not sure if I implemented the email support in the best way but it does work.

1.  Astcc can be easily configured to email you the card numbers and specs on the cards whenever new cards are added.

2.  I have added a button under "cards" that will list all cards in the system and give the available info on each one.
Comments:By: Mark Spencer (markster) 2004-09-04 23:34:54

Do you have a disclaimer on file?

By: Darren Wiebe (darren) 2004-09-05 01:02:31

I'm faxing one in right away.  I will mail it on Tuesday or Wednesday.

By: Darren Wiebe (darren) 2004-09-16 19:03:10

You should have the disclaimer by now.

By: Mark Spencer (markster) 2004-09-16 23:28:35

Looks like a great patch, just one comment...

Creating a tmp file in /tmp with a fixed or predictable name can be the source of a security problem in which someone points some system file to /tmp and when you open it it gets overwritten.  Since you're just sending the output to the mail program, you can also use:

open (FOO, "|$config{mailprog} -s 'some subject'") to open the mail program and write to it directly, then just close(FOO) when you're done.

By: Darren Wiebe (darren) 2004-09-16 23:52:25

Thanks for the tip.  I will make a new patch on the weekend.

By: Darren Wiebe (darren) 2004-09-18 02:11:11

1.  I have corrected the method of calling the mail program.

2.  I have added support to specify the length of card numbers you want.

3.  I have added support to insist that the card numbers start with a particular number.

4.  I have added support to add money to cards.

I'm attaching a new diff file

By: Mark Spencer (markster) 2004-09-18 09:55:26

Looks good to me, added to CVS, thanks!