Summary:	ASTERISK-02328: [patch] Add temporary greetings to voicemail
Reporter:	Jean-Philippe Lord (jplord)	Labels:
Date Opened:	2004-09-02 14:19:07	Date Closed:	2011-06-07 14:05:27
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) vm_tempgreet.patch.txt ( 1) vm-tempgrt-NEW-prompts.tar.gz
Description:	Add the ability to record a temporary greeting that is played in place of the busy or unavailable message when existent. Provide the ability to set an expiry date on the temporary greeting after which it automatically get deleted. No expiry is also valid and the user will then have to manually delete the greeting when coming back. This is an awesome meridian mail feature that would be great to see in Asterisk. Really useful for sick days and holidays to avoid deleting your regular greeting and re-recording it when you come back. ****** ADDITIONAL INFORMATION ****** This was apparently in 156 but has never been done in either 156 or 1483 (Advanced VoiceMail features)
Comments:	By: Jean-Philippe Lord (jplord) 2004-09-02 14:19:30 Anyone working on this at the moment ? By: Russell Bryant (russell) 2004-09-11 12:44:38 I'm working on this now.  This patch adds temporary greetings, but I'm still working on adding the option to set an expire time. This adds option 5 under user options for recording / deleting temporary greetings. Prompts needed for this ... vm-options: add option 5 for temporary greeting menu vm-tempgreeting: "Press 1 to record a new temporary greeting" vm-tempgreeting2: vm-tempgreeting + "Press 2 to delete your current temporary greeting" vm-rec-temp: "After the tone, please record your temporary greeting and press the pound key" By: Russell Bryant (russell) 2004-09-11 13:55:51 vm-tempdeleted: "Current temporary greeting deleted" By: Olle Johansson (oej) 2004-09-12 13:53:33 We need Allison sound files for this. Have you got them? By: Russell Bryant (russell) 2004-09-12 16:28:29 No, I don't have them.  I recorded my own for testing.   Mark mentioned that some prompts were also needed for the MeetMe patch (2314).  I guess we could put them in one big request.  I would take care of it, but I don't know how to go about getting prompts from Allison. By: Jean-Philippe Lord (jplord) 2004-09-20 16:23:33 drumkilla: Some of the sound you're looking for are in the asterisk-sounds CVS tree 3366 Jan 17  2004 to-erase-yr-temp-grtg.gsm 3531 Jan 17  2004 to-rec-yr-temp-grtg.gsm 2541 Jan 17  2004 your-temp-greeting.gsm Please report on what's missing. By: Russell Bryant (russell) 2004-09-20 19:49:35 Sorry, I didn't know that those were there. I put together some prompts by putting some of those things together that you mentioned.  "vm-options" still needs to be changed, though, because I could only add "press 5 to record your temporary greeting" to the end of the file.  I would assume the originals are around somewhere so that it could be rebuilt to have that option before "press star to return to the main menu." I also updated the patch to be compatible with the latest snapshot of CVS. I am still working on the ability to set an expire time for the temporary greeting, but I should have that done sometime soon.  I can just submit it as a new patch. edited on: 09-20-04 19:50 By: Jean-Philippe Lord (jplord) 2004-09-21 06:53:38 Some other sound that were apparently recorded for this purpose: 1815 Jan 17  2004 has-expired.gsm 3168 Jan 17  2004 if-grtg-should-expire-at.gsm 3333 Jan 17  2004 to-change-exp-date.gsm 1617 Jan 17  2004 will-expire.gsm 2112 Jan 17  2004 will-not-expire.gsm By: Russell Bryant (russell) 2004-10-01 23:06:46 I have a disclaimer on file. Also, I think I may have lost all the work I have done on adding the ability to set an expire time.  *sigh* By: Jean-Philippe Lord (jplord) 2004-10-02 10:59:02 I've tested this change and It works great !!! 2 suggestion: I think we need to make temporary greeting #4 and password ASTERISK-1... it does not flow right otherwise. Also, expiry date/time would be great. Good work... drumkilla. also could you test 2302 when you get a chance so it makes CVS one day. By: Russell Bryant (russell) 2004-10-02 22:23:48 I made the change for making it option '4' instead of '5'. The prompt "vm-options" still needs to be made before this can be applied to CVS.   I will see if I can locate the files needed to do this. By: Jean-Philippe Lord (jplord) 2004-10-03 09:51:52 Try this one... vm-options.gsm. I'v adjusted the pitch of option 5 and made it option 4. By: Jean-Philippe Lord (jplord) 2004-10-03 18:11:43 We need the aiff or wav to get better quality audio. If someone can get the original aiff or wav files for vm-options, to-rec-yr-temp-grtg and number 5 that would be great. attach them here and I can do the work. edited on: 10-03-04 18:12 By: twisted (twisted) 2004-10-27 16:27:40 Any update on this?  It's a great idea, that I'm currently implimenting with dialplan logic, but having it built in would be cream. --Housekeeping By: Russell Bryant (russell) 2004-10-27 19:13:11 The patch that is here works fine for temp greetings. The feature to set a time for them to expire isn't done yet.  I haven't worked on it in a while because I have been busy with other things.  If anyone wants the code I have to finish it up, let me know. By: Jean-Philippe Lord (jplord) 2004-10-27 19:30:15 We also need vm-options re-recorded... or the original sound files to re-compress... This is awesome... been using it for awhile now and staff is extremely happy. Expiry date would be great By: twisted (twisted) 2004-11-14 21:27:23.000-0600 Although drumkilla is sitting right beside me, I also know that there is not enough time to continue with this at the present, therfore, I am suspending this one for now. By: Russell Bryant (russell) 2004-11-14 21:31:04.000-0600 I would really like to see this go in, but I just don't have time to work on the sound file. jplord:  If you would like to see this go in, see what you can do about getting a sufficient sound file.  Thanks! By: Jean-Philippe Lord (jplord) 2004-11-16 20:31:46.000-0600 I agree drumkilla. I don't want to loose this one either. The latest sound I've made is just fine. When there's time, we could get vm-options re-recorded but the one provided here is ok ! The patch can be implemented into CVS along with the required prompts which are in vm-tempgrt-NEW-prompts.tar.gz. Both myself and drumkilla have disclaimer on file (as stated earlier in this document.) By: Russell Bryant (russell) 2004-11-21 23:21:52.000-0600 uploaded patch against latest version of app_voicemail in CVS head I just listened to your new version of vm-options.  I think it sounds just fine.  I guess this can make its way in, now. edited on: 11-21-04 23:25 By: Russell Bryant (russell) 2004-11-25 01:49:41.000-0600 added to CVS By: twisted (twisted) 2004-12-02 21:13:22.000-0600 Oops... I just realized this WAS in 156 To make up for that, i'll get the prompts done ;) By: twisted (twisted) 2004-12-02 21:13:53.000-0600 I'm smoking crack. By: Digium Subversion (svnbot) 2008-01-15 15:14:57.000-0600 Repository: asterisk Revision: 4335 U   trunk/apps/app_voicemail.c U   trunk/sounds/vm-options.gsm A   trunk/sounds/vm-rec-temp.gsm A   trunk/sounds/vm-tempgreeting.gsm A   trunk/sounds/vm-tempgreeting2.gsm A   trunk/sounds/vm-tempremoved.gsm U   trunk/sounds.txt ------------------------------------------------------------------------ r4335 | russell | 2008-01-15 15:14:57 -0600 (Tue, 15 Jan 2008) | 2 lines Add temporary greetings to voicemail (bug ASTERISK-2328) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4335