Summary:	ASTERISK-02319: [patch] add verbosity and a warning to app_voicemail
Reporter:	kb1_kanobe2 (kb1_kanobe2)	Labels:
Date Opened:	2004-09-01 21:31:31	Date Closed:	2008-01-15 15:06:32.000-0600
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-voicemail-verbosity.diff
Description:	This trivial patch adds a few level 3 verbosities to elaborate on silence timeout events and abandoned messages. It also adds a startup warning about empty message risk when maxsilence exceeds minmessage length. ****** ADDITIONAL INFORMATION ****** Hopefully level 3 is deep enough - seems consistent with other verbosities in app_voicemail. If not, please feel free to change.
Comments:	By: twisted (twisted) 2004-09-01 23:29:01 We use tabs, not spaces in our code.  Please revise the patch with the correct formatting and resubmit.  Even the very first line in the patch breaks formatting. By: Mark Spencer (markster) 2004-09-01 23:32:00 Do you have a disclaimer on file, by the way? By: kb1_kanobe2 (kb1_kanobe2) 2004-09-02 00:20:11 You're entirely correct of course - I should have reviewed the resulting diff again before submitting. That first block was meaningless and did not belong there. Regarding the spaces, I am not seeing them (cat -T ./asterisk-voice....). Regardless, I cannot upload a replacement file. Mantis is returning: APPLICATION ERROR ASTERISK-11 File upload failed. PHP file uploads may be disabled. Please ask your admin to run the admin_check script to debug this problem. Should I just delete this bug and resubmit? And yes, there is a disclamer.changes on file. By: kb1_kanobe2 (kb1_kanobe2) 2004-09-02 00:24:00 Regarding 'APPLICATION ERROR 0000015', user fault on my part. Obviously Mantis doesn't elaborate on filename collisions. It helped to delete the existing file first... Replacement patch submitted. By: Mark Spencer (markster) 2004-09-02 00:54:26 Added to CVS, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:06:32.000-0600 Repository: asterisk Revision: 3709 U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r3709 | markster | 2008-01-15 15:06:31 -0600 (Tue, 15 Jan 2008) | 2 lines Improve voicemail verbosity (bug ASTERISK-2319) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3709