| Summary: | ASTERISK-02308: [patch] Add verbosity to pbx.c when it can't find a target triplet in the dialplan | ||
| Reporter: | kb1_kanobe2 (kb1_kanobe2) | Labels: | |
| Date Opened: | 2004-09-01 01:39:58 | Date Closed: | 2008-01-15 15:06:27.000-0600 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) asterisk-pbx-verbose-reversion-to-defaults.diff | |
| Description: | This trivial patch adds some verbosity to ast_pbx_run() in pbx.c to help operators understand why the expected target context,exten,priority triplet suddenly develops into exten 's' (and sometimes also context 'default'). ****** ADDITIONAL INFORMATION ****** While debugging a dialplan where 'include => parking' was specified in an isolated context it became apparent pbx.c was fiddling with the post-timeout dialplan target. Specifically, the pbx was restarting in context 'parkinglot' but throwing a Warning that it was '..sent into invalid extension 's' in context 'default''. This was confusing as 'default' does not exist anywhere in my dialplan. Obviously this was a user fault - 'parkinglot,s,1' had not been defined, however it was confusing that the context was silently changing. This patch should help avoid future confusion. | ||
| Comments: | By: Brian West (bkw918) 2004-09-01 11:27:39 verbose in this case is bad.. it should be logged not put on verbose. Asterisk is already too chatty with respect to verbose. By: kb1_kanobe2 (kb1_kanobe2) 2004-09-01 12:25:12 Agreed, too much output is an equally bad thing, however it's very dangerous to have the dialplan making unpublished changes to call flow - in this case I presumed there was a bug because I couldn't see any reason for it to be jumping to a context name that is not declared anywhere in my dialplan. I spent half an hour trolling through the code trying to work out where this 'default' was coming from. Likewise, if this was moved into debug then which debug should it be associated with? I opted for Verbose as at least that can be turned up and down in a channel (and channel type) independant manner on a running system - consider a dialplan with Sip, Zap and IAX channels that has an intermittant dialplan error in the timeout path of the communal parking context... which channel (and/or type) will be the next to experience the issue? By: Brian West (bkw918) 2004-09-01 12:52:40 lets see what Mark says about it :P By: Mark Spencer (markster) 2004-09-01 14:26:39 Added to CVS, thanks. By: Digium Subversion (svnbot) 2008-01-15 15:06:27.000-0600 Repository: asterisk Revision: 3703 U trunk/pbx.c ------------------------------------------------------------------------ r3703 | markster | 2008-01-15 15:06:26 -0600 (Tue, 15 Jan 2008) | 2 lines Slightly more verbose detail on PBX startup (bug ASTERISK-2308) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3703 | ||