| Summary: | ASTERISK-02156: patch from 2174 wrong fix | ||
| Reporter: | cloos (cloos) | Labels: | |
| Date Opened: | 2004-07-30 20:31:02 | Date Closed: | 2008-01-15 15:04:02.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | EDITOR is not the right env to use for this. Having to use vi(m) rather than emacs on remote servers is bad enough; getting stuck with vi strokes in *'s cli too is too much! The proper fix is to document that editline looks for $PWD/.editrc or $HOME/.editrc for setting stuff like this, and to actually enable parsing of .editrc (right now I get stuck with the crappy vi bindings w/o any alternative than having to unset EDITOR when running *. Or fixing the src by reversing the patch. :) Sorry for the rant, but disabling the mixing of proper emacs bindings in readline and editline with the use of vi(m) for EDITOR bites. | ||
| Comments: | By: Mark Spencer (markster) 2004-07-30 22:38:10 As a compromise I made it use AST_EDITOR instead of the traditional EDITOR, that way everywhere you use EDITOR you can make asterisk honor it just by setting an additional variable (or by editing the src) without changing the default behavior on virtually everyones system. By: Digium Subversion (svnbot) 2008-01-15 15:04:02.000-0600 Repository: asterisk Revision: 3547 U trunk/asterisk.c ------------------------------------------------------------------------ r3547 | markster | 2008-01-15 15:04:02 -0600 (Tue, 15 Jan 2008) | 2 lines Respect "AST_EDITOR" rather than "EDITOR" so as not to change the default bindings from emacs to vi (bug ASTERISK-2156) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3547 | ||