| Summary: | ASTERISK-02141: [patch] Show manager command required privileges in output of 'show manager commands' | ||
| Reporter: | Tilghman Lesher (tilghman) | Labels: | |
| Date Opened: | 2004-07-29 14:52:54 | Date Closed: | 2004-09-25 02:12:16 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 20040729__manager_privs.diff.txt | |
| Description: | Currently, the only way to know the necessary privileges to assign to a user is to look through the source code to find what each command's privileges are. This lets the administrator issue a simple command to find the necessary privilege string. | ||
| Comments: | By: Mark Spencer (markster) 2004-07-29 15:25:49 The authority_to_str function isn't quite right, but it's probably not terribly relevant. If you're going to try to make it safe though, you mind as well do it right :) The problem is that the "running total" increases by the legnth no matter whether the full length was copied, and the result is that the length will become a negative number and strncpy does NOT treat a negative number as 0 but as infinity. By: Tilghman Lesher (tilghman) 2004-07-29 15:56:34 OK, fixed. By: Malcolm Davenport (mdavenport) 2004-07-30 16:42:07 Added to CVS. Thank you. | ||