Summary:	ASTERISK-02139: [request + patch] have call queues using a SIP member honor a 302 redirect
Reporter:	scrubb (scrubb)	Labels:
Date Opened:	2004-07-29 09:20:33	Date Closed:	2011-06-07 14:05:32
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_queue.c.unidiff
Description:	I have a call queue with 3 cisco 7940 phones in it.  The queue works great for all advertised purposes.  I am adding the SIP phone to the call queue via the AddQueueMember application. When I try to take advantage of the CfwdAll feature of the phone (which works great in my standard dial plan) the call from the call queue does not respect the 302 Moved Temporarily SIP message.  It gets the message back, but marks the phone as Busy.      -- Executing Queue("Zap/23-1", "tier1||||30") in new stack    -- Started music on hold, class 'default', on Zap/23-1    -- Called PHONE2    -- Got SIP response 302 "Moved Temporarily" back from 10.1.1.83    -- SIP/PHONE2-ea4a is busy The call forwarding from the phone itself in the same manner works fine except in the queue scenario.
Comments:	By: Mark Spencer (markster) 2004-07-29 15:50:36 This will require porting of the code from app_dial.  This is really a feature request. By: cursor_software (cursor_software) 2004-08-02 19:26:28 I have attached a patch that seems to fix the queue forward issue. The patch also incorporates another forward fix, detailed in bug number 2195 (Forwarding issue with multiple dial targets), so the patch in that bug report will have to be applied first. By: cursor_software (cursor_software) 2004-08-04 12:45:25 If anyone installs the above patch, please edit app_queue.c to remove the "o->chan->subchannel = 1;" line.  My bug number 2195 provided an incorrect patch and so "sub-channels" are no longer required. You will still need the 2195 fix, but just not the patch supplied in the 2195 bug report. By: twisted (twisted) 2004-08-24 13:20:38 This is a wakeup call on this bug.  Let's get rolling on this again before I have to close it out for inactivity. By: scrubb (scrubb) 2004-08-24 14:58:52 Is this not staged for CVS? By: cursor_software (cursor_software) 2004-08-25 08:35:20 It is not in CVS, no. As you are the original reporter, have you tried to install the patch to verify that it clears the problem? By: scrubb (scrubb) 2004-08-25 09:01:00 Sadly I have not installed the patch.  It will be a little while before I can.  The environment I am in is 24x7 production and my test environment is about 1 month from being back up.  I will try to schedule an outage window for production here in a little bit ( a week out maybe )to test this.  Thank you for creating the patch.  This will help tremendously! By: scrubb (scrubb) 2004-09-10 09:16:20 Will be testing this patch today or monday :-) By: Olle Johansson (oej) 2004-09-10 15:17:56 cursor_software: I'm a bit confused regarding the need of patch 2195 (that is closed as resolved now). Could you explain what is needed from 2195 now in order to get this patch to work? Regards /Oej By: scrubb (scrubb) 2004-09-10 17:43:10 I applied only this patch (removed the line indicated) and this patch works perfectly.  I'd give it a thumbs up to apply.  Thanks everyone. By: Mark Spencer (markster) 2004-09-11 01:06:03 Is there a disclaimer on file? By: scrubb (scrubb) 2004-09-20 09:17:02 Reminder sent to cursor_software Can you please check on filing a disclaimer.  They can't roll this into CVS without it.  Thanks! By: Mark Spencer (markster) 2004-09-26 13:54:55 Can't apply unless we get a disclaimer.  I'm closing this one out, but feel free to reopen if you get a disclaimer on file or can confirm you already have one, thanks! By: scrubb (scrubb) 2004-09-27 13:55:12 Reminder sent to cursor_software Can you please at least state you intention of disclaiming or not.  If you are not able or willing to disclaim your work, please post a note.  As this patch ages we will have to choose different technology to accomplish this if it is not applied to CVS.  Thanks again for the patch! It is working fabulously in production. By: cursor_software (cursor_software) 2004-09-27 16:16:09 Reminder sent to scrubb I don't seem to be able to add a new bugnote, so I'm using the "reminder" facility. As most of the bug marshals know, I am unable to provide a "disclaimer" for the work I've shared.  The modifications have been published under the same terms as Asterisk itself (the GPL).  I don't have the authority to release code under any other terms.  It's just company policy.  Sorry. I attached my patch to this bug report because it seemed to be the right thing to do.  Since that time, I've been asked to not use this bug tracker to share my patches and, of course, I have complied with that request. My other bug reports with patches, posted prior to the request I mentioned, have either been closed down without action or committed to CVS.  Perhaps the nature of the patch determines whether a "disclaimer" is required. Until a similar "official" facility appears in CVS, you may continue to use the patch I provided.  If you lose the patch in the future then you can email me (kevin@cursor.biz) and I'll create a new diff for you.  Anyone else who needs this facility should also feel free to email me and ask. Please accept my apologies for any inconvenience caused.