[Home]

Summary:ASTERISK-02095: [Post-1.0][patch] Allow adding/removing queue members via manager API
Reporter:dw (dw)Labels:
Date Opened:2004-07-23 10:30:06Date Closed:2011-06-07 14:05:09
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) queue_api-040721-1750.txt
( 1) queue_api-040721-1753.txt
Description:The patch attached below allows a client program connected to Asterisk via the manager to add and remove queue members directly.

****** ADDITIONAL INFORMATION ******

Code style is outlandish for asterisk, may need refactoring; app_queues.c could do with a more general refactoring to avoid the big deep loops. Might be interested in doing this if you are interested.
Comments:By: dw (dw) 2004-07-23 10:32:04

Sorry, forgot "documentation" ;)...


ADD INTERFACE

Action: QueueAdd
Queue: <queue_name>
Interface: <interface_name>
[Penalty: <penalty> (default 0)]


REMOVE INTERFACE

Action: QueueRemove
Queue: <queue_name>
Interface: <interface_name>

By: Olle Johansson (oej) 2004-07-23 10:38:13

Looks very promising. Please read the coding guidelines in your source directory and update :-)

Also, please confirm that you have sent in a disclaimer to Digium.


Thank you for contributing to Asterisk!

/Olle

By: dw (dw) 2004-07-23 12:15:15

Please find a slightly revised patch in queue_api-040721-1753.txt, this one fixes up braces as per the guidelines and also changes indentation to use tabs. Argh, please delete the 17:50 version, it's using spaces for indentation.

Disclaimer faxed at 17:59 BST.

By: Mark Spencer (markster) 2004-07-23 13:52:31

Can we unify the add/remove code from the management interface so that we don't have it duplicated.

By: Tilghman Lesher (tilghman) 2004-07-25 23:06:12

Add/remove interface unified and merged with ASTERISK-2097 -- per Mark's instructions.