ASTERISK-02067: [patch] Add return value check of ast_smoother_feed() before ast_smoother

[Home]

Summary: ASTERISK-02067: [patch] Add return value check of ast_smoother_feed() before ast_smoother_read()

Reporter: Tilghman Lesher (tilghman) Labels:

Date Opened: 2004-07-19 14:31:58 Date Closed: 2011-06-07 14:11:54

Priority: Trivial Regression? No

Status: Closed/Complete Components: Core/General

Versions: Frequency of
Occurrence

Related
Issues:

Environment: Attachments: ( 0) 20040719__smoother_retvalcheck.diff.txt

Description: If ast_smoother_feed() returns an error, a subsequent ast_smoother_read() will cause a segfault on a NULL pointer.

Comments: By: Mark Spencer (markster) 2004-07-19 16:02:12

What situation triggers this?
By: Tilghman Lesher (tilghman) 2004-07-19 16:31:35

I don't have the coredump anymore, but a large number of chan_h323 calls were triggering this crash, which I fixed immediately, but didn't report on the bugtracker due to lack of time. Just trying to get fixes merged back into CVS.
By: Mark Spencer (markster) 2004-07-19 19:13:02

I see nothing in the code to suggest that somehow not being successful to a write to the smoother would somehow make it invalid for reading.

As such, I believe this is a red herring unless you can show me otherwise.