Summary:ASTERISK-02060: dsp.c fails to compile
Reporter:jesses (jesses)Labels:
Date Opened:2004-07-19 02:19:05Date Closed:2004-09-25 02:14:11
Versions:Frequency of
Description:In today's HEAD branch, dsp.c fails to compile if OLD_DSP_ROUTINES are defined and FAX_DETECT is defined in dsp.c

dsp.c: In function `dtmf_detect':
dsp.c:642: error: `DTMF_TO_TOTAL_ENERGY' undeclared (first use in this function)
dsp.c:642: error: (Each undeclared identifier is reported only once
dsp.c:642: error: for each function it appears in.)
dsp.c:401: warning: unused variable `fax_energy_2nd'
make: *** [dsp.o] Error 1
Comments:By: twisted (twisted) 2004-07-19 02:50:28

I don't really think this is a bug, but perhaps we should note somewhere that OLD_DSP_ROUTINES should NOT be defined if we're using FAX_DETECT, or possibly do a #ifdef OLD_DSP_ROUTINES

and vice versa for FAX_DETECT, or will that not work?  (still new to C and defines )

By: Brian West (bkw918) 2004-07-19 09:59:00

do a fresh checkout.. I don't have this error on head

By: twisted (twisted) 2004-07-19 10:13:46

I had him do a fresh checkout on IRC last night.  The problem exists if you define BOTH OLD_DSP_ROUTINES _AND_ FAX_DETECT.  Not just on a default checkout.

By: Mark Spencer (markster) 2004-07-19 12:15:07

Fixed in CVS, but be aware that OLD_DSP_ROUTINES will likely go away before too long!  You can e-mail me off-list if you have a reason that you need them.